This repository was archived by the owner on Jan 14, 2024. It is now read-only.
Glasgow class 6-Cat Smith- JS-Week 2 #452
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregdyke
reviewed
Mar 8, 2023
| */ | ||
| function isAcceptableUser(userAge, isLoggedIn) {} | ||
| function isAcceptableUser(userAge, isLoggedIn) { | ||
| let UserisAcceptable = userAge >= 18 && isLoggedIn |
There was a problem hiding this comment.
That is a great name for this variable. The convention in javascript (at CYF - otherwise it might depend on the company you work for, but most probably have similar conventions) is for variable names to begin with a lower case (andThenHaveUpperCase)
|
|
||
| function applyDiscount(totalPrice) {} | ||
| function applyDiscount(totalPrice) { | ||
| let percent; |
There was a problem hiding this comment.
You seem to not have automatic code formatting turned on. This is really important for it to be easy to read your code. Could you take a look at the instructions in the readme of the coursework for week 1? It should say how to enable format on save. It might be blocked by having auto-save turned on, or by 2 formatters conflicting with each other. Ask your buddy or someone on Saturday to help you
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?