Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mandatory/1-fix-functions.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@

*/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these functions look good to me 👍

function getMood() {
let isHappy = true;
function getMood(isHappy) {
//let isHappy = true;

if (isHappy) {
return "I am happy";
Expand All @@ -21,7 +21,7 @@ function getMood() {
}

function greaterThan10(num) {
let isBigEnough;
let isBigEnough = num > 10;

if (isBigEnough) {
return "num is greater than 10";
Expand Down
50 changes: 44 additions & 6 deletions mandatory/2-function-creation.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,13 @@
1. the user should be 18 or older
2. the user must be logged in
*/
function isAcceptableUser(userAge, isLoggedIn) {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think you could simplify the code in a few ways...

  1. If you have an if statement that looks like this: if(isLoggedIn === true) - you can write this instead: if(isLoggedIn) - can you think of why that works?
  2. Can you think of a way to write this function without the if statement? Maybe you can write it with only a return statement?

function isAcceptableUser(userAge, isLoggedIn) {

if (userAge >= 18 && isLoggedIn === true) {
return true
}
else {return false}
}

/*
Complete the function to apply discount percent based on how much is totalPrice in user cart.
Expand All @@ -15,26 +21,53 @@ function isAcceptableUser(userAge, isLoggedIn) {}
is applieds and 142.5 should be returned)
*/

function applyDiscount(totalPrice) {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

function applyDiscount(totalPrice) {
if (totalPrice > 200) {
return (totalPrice - (totalPrice/100) * 10)
}
else {return (totalPrice - (totalPrice/100) * 5)}

}

/*
Complete the function to print to the console the odd numbers between 1 and limit (use a while loop):
*/
function printOddNumbers(limit) {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

function printOddNumbers(limit) {
let number = 0;
while (number < limit) {
number = number + 1;
if (number%2 === 0) continue;
console.log(number);
}
}

/*
Complete the buyTwoGetTheCheapestFree function: if user buys two items, the cheapest item will be free!
The function should return the price to be paid once the discount is applied.
*/
function buyTwoGetTheCheapestFree(price1, price2) {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks almost perfect.
Try to keep an eye on your indentation and spacing in the code. Even though it seems like it doesn't matter - it can make it much easier for other developers to read and understand your code 😄

function buyTwoGetTheCheapestFree(price1, price2) {
if (price1 > price2){
return price1;}
else {
return price2;
}
}

/*
Complete the function to determine if it is suitable for a person to register based on their age!
- if the person is 12 or younger it should return "You Are Too Young To Register"
- if the person is older than 12 and younger than 90 it should return "You Can Register"
- if the person is 90 or older it should return "You Don't Need To Register"
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good as well!

function canRegister(age) {}
function canRegister(age) {
if (age <= 12) {
return "You Are Too Young To Register";
}
if (age > 12 && age < 90){
return "You Can Register";
}
else {return "You Don't Need To Register"}
}

/*
Complete the function so that it prints out to the console numbers in reverse order starting at
Expand All @@ -45,7 +78,12 @@ function canRegister(age) {}
)
*/

function countReverse(number) {}
function countReverse(number) {
while (number > 0){
console.log (number);
number = number - 1;
}
}

/* ======= TESTS - DO NOT MODIFY ===== */

Expand Down