Glasgow | 25-ITP-Sep | Mohammed Abdoon | Sprint 3| Qoute Generator #851
Conversation
M-Abdoon
added
the
Needs Review
tee4tao
added
Review in progress
Sprint-3/quote-generator/quotes.js
Outdated
| quoteText["textContent"] = `“${randomQuote.quote}”`; | ||
| authorText["textContent"] = `- ${randomQuote.author}`; |
There was a problem hiding this comment.
quoteText["textContent"] works but there is a cleaner and a more conventional way to set textContent. Can you update it to the more standard approach?
There was a problem hiding this comment.
Yes. I just updated the code. I used the standard way. which is quoteText.textContent instead of quoteText["textContent"] .
Sprint-3/quote-generator/quotes.js
Outdated
| showRandomQuote(); | ||
| } | ||
|
|
||
| window.onload = setup; |
There was a problem hiding this comment.
Your code is clean and well-organized, and wrapping everything inside a setup() function is a good way to avoid global variables. However, window.onload waits for images, fonts, and external files to finish loading, which makes it slower than necessary. Can you think of a different event or method that would allow your setup code to run as soon as the HTML is ready?
There was a problem hiding this comment.
Sure. I used document.addEventListener("DOMContentLoaded", setup); insteadinstead so the setup runs as soon as the HTML is ready.
tee4tao
added
Reviewed
M-Abdoon
added
Needs Review
|
The changes have been made. Thank you. |
tee4tao
added
Review in progress
2 participants
Learners, PR Template
Self checklist
Changelist
Quote generator app exercise done.
Questions
No questions so far, thank you.