London | 25-SDC-July | Ali Qassab | Module-Legacy-Code | Sprint 1 | Bug/hashtag slowing down the browser #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliQassab
added
the
Needs Review
- Only fetch hashtag data once to prevent repeated API calls - Fixes infinite state-change event loop - Resolves browser performance issues Fixes CodeYourFuture#3
AliQassab
force-pushed
the
bug/Hashtag-slowing-down-the-browser
branch
from
17397dd to
1d03200
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Problem:
Clicking on hashtags caused an infinite loop of API requests, making the browser sluggish and overwhelming the server with dozens of repeated requests.
Root Cause:
State-change events were triggering handleRouteChange() → hashtagView() → getBloomsByHashtag() → state update → repeat infinitely.
Solution:
Added a simple check to only fetch hashtag data if it's not already loaded for the current hashtag.
Questions
The Bug report should be: