Skip to content

Conversation

@enjoy15
Copy link

@enjoy15 enjoy15 commented Oct 15, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

#Changelist

-Completed all excercises in Sprint-3

@enjoy15 enjoy15 added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 15, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Oct 25, 2025

Please hold on creating new PRs for Sprint-3 exercise. I am asking for permission to accept also Sprint-3 exercise submitted in one PR.

On separate note, why set the branch name to coursework/sprint-3-implement-and-rewrite/implement/1-get-angle-type?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 25, 2025
@enjoy15
Copy link
Author

enjoy15 commented Oct 25, 2025

Please hold on creating new PRs for Sprint-3 exercise. I am asking for permission to accept also Sprint-3 exercise submitted in one PR.

On separate note, why set the branch name to coursework/sprint-3-implement-and-rewrite/implement/1-get-angle-type?

Thanks for the feedback! I initially named the branch that way because I thought a separate PR was required for each file. Later, I realized that wasn’t necessary, but I continued working on the same branch. I wasn’t sure how to rename the branch, so I decided to keep it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants