Skip to content

London | 25-ITP-Sep | Shaghayegh Shirinfar | Sprint 3 | implement-and-rewrite-tests #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 25 commits into from
Closed

London | 25-ITP-Sep | Shaghayegh Shirinfar | Sprint 3 | implement-and-rewrite-tests #789

wants to merge 25 commits into from

Conversation

@shaghayeghfar
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

@shaghayeghfar shaghayeghfar added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 22, 2025
@shaghayeghfar shaghayeghfar mentioned this pull request Oct 22, 2025
Open
@jennethydyrova jennethydyrova mentioned this pull request Oct 26, 2025
Closed
4 tasks
@cjyuan
Copy link
Contributor

cjyuan commented Oct 27, 2025

Both of your Sprint-3 PRs contains modified files in Sprint-1 and Sprint-2 folders but those files are not related to Sprint-3 exercise. Can you revert the changes made in those two folders (in both of your Sprint-3 branches)?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 27, 2025
@shaghayeghfar
Copy link
Author

@cjyuan
Dear CJ
Thank you for reviewing my pull request. I realized that instead of creating a new branch from the main branch, I accidentally created it from wherever I was in Git at the time. This made things a bit messy and incorrect.

I’ve now created a clean branch and will close this pull request.

Thank you for your time and help!

@shaghayeghfar
Copy link
Author

wrong one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shaghayeghfar @cjyuan