West Midlands | ITP-Sept-2025 | Ali Naru | Sprint 3 | Coursework/sprint 3 implement and rewrite #845
+133
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohammedNaru
force-pushed
the
coursework/sprint-3-implement-and-rewrite
branch
4 times, most recently
from
e7b4c8b to
d40619a
Compare
MohammedNaru
force-pushed
the
coursework/sprint-3-implement-and-rewrite
branch
from
d40619a to
5dc9452
Compare
MohammedNaru
force-pushed
the
coursework/sprint-3-implement-and-rewrite
branch
from
9ac8d6e to
6082322
Compare
…corresponding tests
…lete assertions for all test cases
… face cards, and invalid inputs
…ds, face cards, Aces, and invalid inputs
MohammedNaru
added
Needs Review
cjyuan
added
Review in progress
cjyuan
reviewed
Nov 15, 2025
Comment on lines
+12
to
16
| if (Math.abs(numerator) < denominator) { | ||
| return true; | ||
| } else { | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
The spec wasn't clear enough.
How would you change your code if denominator can also be negative?
Comment on lines
+25
to
+27
| if (!isNaN(rank)) { | ||
| return Number(rank); | ||
| } |
Contributor
There was a problem hiding this comment.
In JavaScript, strings that represent valid numeric literals in the language can be safely
converted to equivalent numbers or parsed into a valid integers.
For examples, "0002", "0x04", "3.1416", "1111", "3e0".
Do you want to recognize these string values as valid ranks?
Does your function behave the way you expect when rank is one of these values?
Comment on lines
+17
to
+21
| // When the numerator is negative but absolute value < denominator, | ||
| // Then the function should return true | ||
| test("should return true for a negative proper fraction (|numerator| < denominator)", () => { | ||
| expect(isProperFraction(-4, 7)).toEqual(true); | ||
| }); |
Contributor
There was a problem hiding this comment.
To make the tests cover all possible categories, you can consider including a test for negative improper fractions.
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coursework/sprint 3 implement and rewrite
Self checklist
Changelist
Pull request complete, all tests working and passed successfully
Questions
no current questions for review.