Skip to content

West Midlands | ITP-Sept-2025 | Ali Naru | Sprint 3 | coursework/sprint-3-practice-tdd #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

West Midlands | ITP-Sept-2025 | Ali Naru | Sprint 3 | coursework/sprint-3-practice-tdd #880

wants to merge 6 commits into from

Conversation

@MohammedNaru
Copy link

@MohammedNaru MohammedNaru commented Nov 14, 2025 •
edited
Loading

Practice TDD Pull Request

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

All tasks complete and pushed successfully, tests have all passed.

Questions

no questions

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@MohammedNaru MohammedNaru changed the title Add test case for character not found in string count.test.js West Midlands | ITP-Sept-2025 | Nov 14, 2025
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@MohammedNaru MohammedNaru changed the title West Midlands | ITP-Sept-2025 | West Midlands | ITP-Sept-2025 | Ali Naru | Sprint 3 | coursework/sprint-3-practice-tdd Nov 14, 2025
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@MohammedNaru MohammedNaru added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Nov 14, 2025
cjyuan
cjyuan reviewed Nov 15, 2025
View reviewed changes
@cjyuan
Copy link
Contributor

cjyuan commented Nov 15, 2025

Can you also update the PR description to make it more informative?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 15, 2025
@MohammedNaru
Copy link
Author

MohammedNaru commented Nov 15, 2025

Can you also update the PR description to make it more informative?

I have now updated this, please review.

@MohammedNaru MohammedNaru added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 15, 2025
@cjyuan
Copy link
Contributor

cjyuan commented Nov 16, 2025

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 16, 2025
@MohammedNaru MohammedNaru mentioned this pull request Nov 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MohammedNaru @cjyuan