Manchester | 25-ITP-Sep | Mahtem T. Mengstu | Sprint 3 | coursework/sprint-3-stretch-Fixed #884 #889
+70
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mahtem
added
📅 Sprint 3
4 tasks
cjyuan
reviewed
Nov 21, 2025
Comment on lines
+27
to
+49
| test("password has at least one uppercase", () => { | ||
| const password = "Uo85*"; | ||
| const result = isValidPassword(password, previousPasswords); | ||
| expect(result).toEqual(true);npx | ||
| }); | ||
|
|
||
| test("password has at least one lowercase", () => { | ||
| const password = "Qf#45"; | ||
| const result = isValidPassword(password, previousPasswords); | ||
| expect(result).toEqual(true); | ||
| }); | ||
|
|
||
| test("password has at least one number", () => { | ||
| const password = "Cz!35"; | ||
| const result = isValidPassword(password, previousPasswords); | ||
| expect(result).toEqual(true); | ||
| }); | ||
|
|
||
| test("password has at least one special symbol", () => { | ||
| const password = "Re*19"; | ||
| const result = isValidPassword(password, previousPasswords); | ||
| expect(result).toEqual(true); | ||
| }); |
Contributor
There was a problem hiding this comment.
For each of these test case, we should also test if the function can correctly return false when a password meets all criteria except the one specified in the test description.
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
In this section, functions to find a char in a string, and a password validator were implemented and tested.
Questions
No questions...