Add ZeroClick ad fallback#642
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds ZeroClick as a web ad provider and switches CLI Gravity fallback traffic from Carbon to ZeroClick while keeping Carbon available on the backend for existing clients.
The backend normalizes ZeroClick offers, stores served ads for local impression validation, and skips server-side ZeroClick impression firing because the CLI now posts ZeroClick impression IDs directly from the client device.
The CLI carries provider/impression metadata through the ad banner, avoids caching ZeroClick offers for later reuse, and still records local impression state after successful ZeroClick reporting.
Validation
Ran
bun --cwd cli typecheck,bun --cwd web typecheck,git diff --check, and live ZeroClick offer/impression/click smoke requests.