Skip to content

[codex] Improve binary spawn errors #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jahooma merged 1 commit into from
May 22, 2026
Merged

[codex] Improve binary spawn errors #724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 67 additions & 16 deletions cli/release/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,22 +490,14 @@ async function checkForUpdates(runningProcess, exitListener) {

await downloadBinary(latestVersion)

const newChild = spawn(CONFIG.binaryPath, process.argv.slice(2), {
stdio: 'inherit',
detached: false,
})
const newChild = spawnInstalledBinary({ detached: false })

newChild.on('exit', (code, signal) => {
resetTerminal()
printCrashDiagnostics(code, signal)
process.exit(signal ? 1 : (code || 0))
})

newChild.on('error', (err) => {
console.error('Failed to start codebuff:', err.message)
process.exit(1)
})

return new Promise(() => {})
}
} catch (error) {
Expand Down Expand Up @@ -561,13 +553,77 @@ function printCrashDiagnostics(code, signal) {
console.error('')
}

async function main() {
await ensureBinaryExists()
function getInstalledBinaryStatus() {
try {
const stats = fs.statSync(CONFIG.binaryPath)
return stats.isFile() ? `yes (${formatBytes(stats.size)})` : 'no'
} catch {
return 'no'
}
}

function printSpawnFailure(err) {
resetTerminal()
const code = err && err.code ? ` (${err.code})` : ''

console.error(`Failed to start ${packageName}: ${err.message}${code}`)
console.error('')
console.error('System info:')
console.error(` Platform: ${process.platform} ${process.arch}`)
console.error(` Node: ${process.version}`)
console.error(` Binary: ${CONFIG.binaryPath}`)
console.error(` Exists: ${getInstalledBinaryStatus()}`)

if (process.platform === 'win32') {
console.error('')
console.error(
'On Windows, this can happen when Windows Security or antivirus blocks',
)
console.error(
'or quarantines the downloaded executable, or when the binary requires',
)
console.error('CPU instructions that are not available on this machine.')
}

console.error('')
console.error('Try deleting the downloaded files and running again:')
console.error(` ${CONFIG.configDir}`)
console.error('')
}

function spawnInstalledBinary(options = {}) {
if (!fs.existsSync(CONFIG.binaryPath)) {
try {
if (fs.existsSync(CONFIG.metadataPath)) fs.unlinkSync(CONFIG.metadataPath)
} catch {
// best effort
}
const error = new Error(
`downloaded binary is missing at ${CONFIG.binaryPath}`,
)
error.code = 'BINARY_MISSING'
printSpawnFailure(error)
process.exit(1)
}

const child = spawn(CONFIG.binaryPath, process.argv.slice(2), {
stdio: 'inherit',
...options,
})

child.on('error', (err) => {
printSpawnFailure(err)
process.exit(1)
})

return child
}

async function main() {
await ensureBinaryExists()

const child = spawnInstalledBinary()

const exitListener = (code, signal) => {
resetTerminal()
printCrashDiagnostics(code, signal)
Expand All @@ -576,11 +632,6 @@ async function main() {

child.on('exit', exitListener)

child.on('error', (err) => {
console.error('Failed to start codebuff:', err.message)
process.exit(1)
})

setTimeout(() => {
checkForUpdates(child, exitListener)
}, 100)
Expand Down
83 changes: 67 additions & 16 deletions freebuff/cli/release/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,22 +477,14 @@ async function checkForUpdates(runningProcess, exitListener) {

await downloadBinary(latestVersion)

const newChild = spawn(CONFIG.binaryPath, process.argv.slice(2), {
stdio: 'inherit',
detached: false,
})
const newChild = spawnInstalledBinary({ detached: false })

newChild.on('exit', (code, signal) => {
resetTerminal()
printCrashDiagnostics(code, signal)
process.exit(signal ? 1 : (code || 0))
})

newChild.on('error', (err) => {
console.error('Failed to start freebuff:', err.message)
process.exit(1)
})

return new Promise(() => {})
}
} catch (error) {
Expand Down Expand Up @@ -548,13 +540,77 @@ function printCrashDiagnostics(code, signal) {
console.error('')
}

async function main() {
await ensureBinaryExists()
function getInstalledBinaryStatus() {
try {
const stats = fs.statSync(CONFIG.binaryPath)
return stats.isFile() ? `yes (${formatBytes(stats.size)})` : 'no'
} catch {
return 'no'
}
}

function printSpawnFailure(err) {
resetTerminal()
const code = err && err.code ? ` (${err.code})` : ''

console.error(`Failed to start ${packageName}: ${err.message}${code}`)
console.error('')
console.error('System info:')
console.error(` Platform: ${process.platform} ${process.arch}`)
console.error(` Node: ${process.version}`)
console.error(` Binary: ${CONFIG.binaryPath}`)
console.error(` Exists: ${getInstalledBinaryStatus()}`)

if (process.platform === 'win32') {
console.error('')
console.error(
'On Windows, this can happen when Windows Security or antivirus blocks',
)
console.error(
'or quarantines the downloaded executable, or when the binary requires',
)
console.error('CPU instructions that are not available on this machine.')
}

console.error('')
console.error('Try deleting the downloaded files and running again:')
console.error(` ${CONFIG.configDir}`)
console.error('')
}

function spawnInstalledBinary(options = {}) {
if (!fs.existsSync(CONFIG.binaryPath)) {
try {
if (fs.existsSync(CONFIG.metadataPath)) fs.unlinkSync(CONFIG.metadataPath)
} catch {
// best effort
}
const error = new Error(
`downloaded binary is missing at ${CONFIG.binaryPath}`,
)
error.code = 'BINARY_MISSING'
printSpawnFailure(error)
process.exit(1)
}

const child = spawn(CONFIG.binaryPath, process.argv.slice(2), {
stdio: 'inherit',
...options,
})

child.on('error', (err) => {
printSpawnFailure(err)
process.exit(1)
})

return child
}

async function main() {
await ensureBinaryExists()

const child = spawnInstalledBinary()

const exitListener = (code, signal) => {
resetTerminal()
printCrashDiagnostics(code, signal)
Expand All @@ -563,11 +619,6 @@ async function main() {

child.on('exit', exitListener)

child.on('error', (err) => {
console.error('Failed to start freebuff:', err.message)
process.exit(1)
})

setTimeout(() => {
checkForUpdates(child, exitListener)
}, 100)
Expand Down
Loading