Skip to content

Conversation

@patrickevans29
Copy link
Contributor

Description

I have created a new term entry for the str() method under the Dunder Methods concept. I closely followed the structure of the pre-existing init and repr methods.

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

@CLAassistant
Copy link

CLAassistant commented Jan 3, 2023

CLA assistant check
All committers have signed the CLA.

@patrickevans29 patrickevans29 changed the title Added __str__() term to Python Dunder Methods #1363 Added __str__() term to Python Dunder Methods Jan 3, 2023
@KTom101 KTom101 linked an issue Jan 5, 2023 that may be closed by this pull request
3 tasks
@SSwiniarski SSwiniarski added python Python entries new entry New entry or entries status: under review Issue or PR is currently being reviewed labels Jan 5, 2023
@SSwiniarski SSwiniarski self-assigned this Jan 5, 2023
Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrickevans29, I did a first review and left a few comments, mostly regards to spacing in the code. We use two spaces to indent, rather than tabs.

SSwiniarski and others added 7 commits January 5, 2023 12:10
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
@patrickevans29
Copy link
Contributor Author

Thanks @SSwiniarski I've just commited those changes.

Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrickevans29, looks good for a second review.

@Dusch4593 Dusch4593 self-requested a review January 13, 2023 15:31
@Dusch4593 Dusch4593 self-assigned this Jan 13, 2023
@Dusch4593 Dusch4593 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Jan 13, 2023
Copy link
Contributor

@Dusch4593 Dusch4593 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrickevans29 Just had a few comments/suggestions. Looks solid already, though! 👍🏻

@Dusch4593 Dusch4593 added status: waiting for author and removed status: under review Issue or PR is currently being reviewed labels Jan 13, 2023
Copy link
Contributor

@Dusch4593 Dusch4593 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrickevans29 This looks good to merge! 👍🏻

I made the following edits in 82abab4 before doing so:

  • Slight rephrase on line # 21.
  • Added empty line between end of ```pseudo snippet and new text (to get the GitHub checks to pass).
  • Specified different ways __str__() is called on line # 33 under "Codebyte Example."
    • Changed variable name to home since this is the only Home object used in the example.

@Dusch4593 Dusch4593 merged commit 40b0f69 into Codecademy:main Jan 14, 2023
@github-actions
Copy link

👋 @patrickevans29
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

@Dusch4593
Copy link
Contributor

Congrats and thank you for contributing to Codecademy Docs! 😄

The new entry should now be live: https://www.codecademy.com/resources/docs/python/dunder-methods/str

Currently, your profile is anonymously listed on the entry page. To make it visible, you'll need to do the following:

  1. Ensure you are using the same email address for your GitHub and Codecademy accounts.
  2. Add your GitHub username to your Codecademy profile.
  3. Log out of Codecademy.
  4. Log back into Codecademy through your GitHub account.

Screen Shot 2023-01-14 at 2 13 08 PM

Looking forward to your next Docs contribution! 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Term Entry] Python Dunder Methods: __str__()

4 participants