Skip to content

Added documentation for matplotlib.pyplot.scatter() #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 6, 2023
Merged

Added documentation for matplotlib.pyplot.scatter() #1755

merged 10 commits into from
Mar 6, 2023

Conversation

@alekseymor
Copy link
Contributor

@alekseymor alekseymor commented Mar 2, 2023

Description

Added documentation for the scatter() function of matplotlib library.
Closes #1662

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

@CLAassistant
Copy link

CLAassistant commented Mar 2, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@SSwiniarski SSwiniarski self-assigned this Mar 2, 2023
@SSwiniarski SSwiniarski added new entry New entry or entries matplotlib Python:Matplotlib entries status: under review Issue or PR is currently being reviewed labels Mar 2, 2023
SSwiniarski
SSwiniarski suggested changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alekseymor I did a first review and found this a pretty solid entry. My comments are mostly typos and a few formatting issues.

@alekseymor alekseymor requested a review from SSwiniarski March 2, 2023 19:47
SSwiniarski
SSwiniarski approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alekseymor Looks good for review two.

@caupolicandiaz caupolicandiaz added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Mar 3, 2023
caupolicandiaz
caupolicandiaz suggested changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@caupolicandiaz caupolicandiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alekseymor I've added my comments. Please update and tag me when you've finished making changes. Thanks

@alekseymor
Copy link
Contributor Author

alekseymor commented Mar 5, 2023

Thanks for the feedback @caupolicandiaz. I've made the changes you requested. Back to you :)

caupolicandiaz
caupolicandiaz approved these changes Mar 5, 2023
View reviewed changes
Copy link
Contributor

@caupolicandiaz caupolicandiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alekseymor Looks good.

@SSwiniarski SSwiniarski merged commit d4e178d into Codecademy:main Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

👋 @alekseymor
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

@SSwiniarski
Copy link
Contributor

SSwiniarski commented Mar 6, 2023

@alekseymor Congrats on your new contribution. The live link is here:https://www.codecademy.com/resources/docs/matplotlib/pyplot/scatter

You're currently listed as an anonymous contributor. If you want to be credited follow the instructions below to add your GitHub username to your Codecademy profile. If not, there is nothing more you need to do.
image

To add your GitHub username to your Codecademy profile:

1.) Add your GitHub Username to your Codecademy Profile Details, you can get there on your desktop by pressing on your profile picture in the upper right-hand corner and selecting "Profile" in the drop-down box:
image

2.) Then log out and log back into Codecademy using your GitHub login:
image

Pavan-Nambi pushed a commit to Pavan-Nambi/docs that referenced this pull request Apr 12, 2023
@alekseymor @SSwiniarski @Pavan-Nambi
Added documentation for matplotlib.pyplot.scatter() (Codecademy#1755)
737e136 
* Added documentation for matplotlib.pyplot.scatter()

* Revisions based on feedback from SSwiniarski.

* Feedback from @caupolicandiaz incorporated.

* prettier formatting

---------

Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@caupolicandiaz caupolicandiaz caupolicandiaz approved these changes

@SSwiniarski SSwiniarski SSwiniarski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SSwiniarski SSwiniarski

Labels

matplotlib Python:Matplotlib entries new entry New entry or entries status: review 1️⃣ completed status: review 2️⃣ completed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Term Entry] Matplotlib pyplot: scatter

4 participants

@alekseymor @CLAassistant @SSwiniarski @caupolicandiaz