Skip to content

Conversation

@JoyelJohny
Copy link
Contributor

Description

  • Adding replaceAll.md which consist of replaceAll strings method of the topic Javascript

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoyelJohny I did a first review and left a few comments.

JoyelJohny and others added 5 commits October 9, 2023 08:27
…l.md

Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
…l.md


Updated example

Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
…l.md


Updated description

Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Updated Shell Output
Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoyelJohny Looks good for a second review.

@yangc95 yangc95 merged commit f766efc into Codecademy:main Oct 9, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

👋 @JoyelJohny
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/javascript/strings/replaceAll

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@KTom101 KTom101 added the hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest javascript JavaScript entries new entry New entry or entries status: review 1️⃣ completed status: review 2️⃣ completed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants