Skip to content

Conversation

@nsLittle
Copy link

Description

Issue Solved

Type of Change

  • Updating the documentation

Checklist

  • [x ] All writings are my own.
  • [x ] My entry follows the Codecademy Docs style guide.
  • [x ] My changes generate no new warnings.
  • [x ] I have performed a self-review of my own writing and code.
  • [x ] I have checked my entry and corrected any misspellings.
  • [x ] I have made corresponding changes to the documentation if needed.
  • [x ] I have confirmed my changes are not being pushed from my forked main branch.
  • [x ] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [x ] I have linked any issues that are relevant to this PR in the Issues Solved section.

@ishg-153 ishg-153 self-assigned this Feb 13, 2024
Copy link
Contributor

@ishg-153 ishg-153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nsLittle A couple of things..

  1. When I suggest changes push them to the same branch (also good thing you created a separate branch as working on the main creates problems) this means no need to create a new PR every time.
  2. You need to remove the images you had previously added to the media folder- logo.png, open-positions.png, and text-link.png.
  3. Since you will be adding gifs, download the gif and add it to the media folder then link it in the following format
    https://raw.githubusercontent.com/Codecademy/docs/main/media/ followed by the gif name.

@ishg-153
Copy link
Contributor

@nsLittle I checked out the loom video link you added, and it's great that you took the time to create that. But for the gif, we expect something like the example here. I'm sure if you download and cut the video you can use that to create a gif using any video to gif website available.

@ishg-153 ishg-153 added html HTML entries hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest enhancement New feature or request status: review 1️⃣ completed status: waiting for author and removed hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest labels Feb 13, 2024
@ishg-153 ishg-153 linked an issue Feb 13, 2024 that may be closed by this pull request
3 tasks
@nsLittle
Copy link
Author

I embedded gifs.

Copy link
Contributor

@ishg-153 ishg-153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nsLittle it is preferred that the gifs have no watermark, please let me know if you can remove that or if you need any help with doing so.

Can you please remove the previously added images from the media folders logo.png open-positions.png and text-link.png

@nsLittle
Copy link
Author

.png files deleted. TY.

@ishg-153
Copy link
Contributor

@nsLittle The gifs you are using have a watermark, is it possible to remove or blur them out? We prefer not to have watermarks on media.

@nsLittle
Copy link
Author

nsLittle commented Feb 15, 2024 via email

@KTom101
Copy link
Contributor

KTom101 commented Feb 26, 2024

@nsLittle You can use Convertio to upload your video and convert it into a gif for free.

@ishg-153
Copy link
Contributor

@nsLittle Were you able to get a watermark-free gif using @KTom101 's suggestion?

@ishg-153 ishg-153 removed a link to an issue Mar 15, 2024
3 tasks
@ishg-153
Copy link
Contributor

@nsLittle Due to lack of response on your end I will have to close this PR.

@ishg-153 ishg-153 closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants