-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Issue #3231: new media added #4365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ishg-153
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nsLittle A couple of things..
- When I suggest changes push them to the same branch (also good thing you created a separate branch as working on the
maincreates problems) this means no need to create a new PR every time. - You need to remove the images you had previously added to the media folder-
logo.png,open-positions.png, andtext-link.png. - Since you will be adding gifs, download the gif and add it to the
mediafolder then link it in the following format
https://raw.githubusercontent.com/Codecademy/docs/main/media/followed by the gif name.
|
@nsLittle I checked out the loom video link you added, and it's great that you took the time to create that. But for the gif, we expect something like the example here. I'm sure if you download and cut the video you can use that to create a gif using any video to gif website available. |
|
I embedded gifs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nsLittle it is preferred that the gifs have no watermark, please let me know if you can remove that or if you need any help with doing so.
Can you please remove the previously added images from the media folders logo.png open-positions.png and text-link.png
|
.png files deleted. TY. |
|
@nsLittle The gifs you are using have a watermark, is it possible to remove or blur them out? We prefer not to have watermarks on media. |
|
My apologies. I wanted to only use free services, so I tried using Loom
(it doesn't allow for free download, nor conversion to gif), and settled on
using Vimeo (it allows for screen video plus conversion to gif, albeit with
the watermark). I've searched around elsewhere, but seem to only come upon
paid services. Do you know of any service, or set of services, that would
allow me to videotape a browser window and turn the video into a gfi?
…On Thu, Feb 15, 2024 at 12:41 PM Ishwari Garge ***@***.***> wrote:
@nsLittle <https://github.com/nsLittle> The gifs you are using have a
watermark, is it possible to remove or blur them out? We prefer not to have
watermarks on media.
—
Reply to this email directly, view it on GitHub
<#4365 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCOZZRXGMRRYN3F7N3ZMYIDYTZCEVAVCNFSM6AAAAABDGQ4X7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBWG4ZDOMBYGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@nsLittle Due to lack of response on your end I will have to close this PR. |
Description
Issue Solved
Type of Change
Checklist
mainbranch.Issues Solvedsection.