Skip to content

Conversation

@Jamesllllllllll
Copy link
Contributor

Description

This is a new PR for the correct file. The previous PR was incorrectly editing the main overflow term page located at /content/css/concepts/overflow/overflow.md - but this one is editing the correct file at /content/css/concepts/overflow/overflow/overflow.md

Issue Solved

Closes #4415

Type of Change

  • Editing an existing entry (add media)

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@Jamesllllllllll
Copy link
Contributor Author

Hey @helfese and @avdhoottt - I closed my previous PR because it was editing the wrong file. This new PR is editing the correct file!

@ishg-153 ishg-153 self-assigned this Mar 6, 2024
Copy link
Contributor

@ishg-153 ishg-153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jamesllllllllll good for second review!

@avdhoottt avdhoottt self-assigned this Mar 10, 2024
@avdhoottt avdhoottt added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Mar 10, 2024
Copy link
Collaborator

@avdhoottt avdhoottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Excellent image.

@avdhoottt avdhoottt added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Mar 10, 2024
@avdhoottt avdhoottt merged commit d64918b into Codecademy:main Mar 10, 2024
@github-actions
Copy link

👋 @Jamesllllllllll
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/css/overflow/overflow

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@Jamesllllllllll Jamesllllllllll deleted the edit/css-overflow branch March 10, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Edit] CSS [Edit] CSS overflow: overflow

3 participants