Edits and new content for General, Python, and SQL #808

Dusch4593 · 2022-06-14T19:00:29Z

Description

Per our target keyword work.

Type of Change

Adding a new entry
Editing an existing entry (fixing a typo, bug, issues, etc)

Checklist

All writings are my own.
My entry follows the Codecademy Docs style guide.
My changes generate no new warnings.
I have performed a self-review of my own writing and code.
I have checked my entry and corrected any misspellings.
I have made corresponding changes to the documentation if needed.
I have confirmed my changes are not being pushed from my forked main branch.
I have confirmed that I'm pushing from a new branch named after the changes I'm making.
Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

SSwiniarski

@Dusch4593, I did a first review and had a few suggestions.

content/python/concepts/glob-module/glob-module.md

content/python/concepts/glob-module/terms/glob/glob.md

content/sql/concepts/commands/terms/group-by/group-by.md

content/sql/concepts/commands/commands.md

Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>

Dusch4593 · 2022-06-15T17:03:59Z

@SSwiniarski Applied your comments/suggestions. 😄

SSwiniarski

Looks good for next review.

caupolicandiaz

@Dusch4593 some edits and small discrepancies

content/general/concepts/database/terms/index/index.md

content/general/concepts/encapsulation/encapsulation.md

content/general/concepts/urn/urn.md

content/python/concepts/files/files.md

content/python/concepts/glob-module/glob-module.md

content/python/concepts/modules/modules.md

content/python/concepts/os-path-module/terms/join/join.md

Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>

…4593/docs into py-gen-sql-target-keywords

Dusch4593 · 2022-06-15T23:11:09Z

@caupolicandiaz Finished implementing your feedback save for one more suggestion.

caupolicandiaz · 2022-06-16T16:56:32Z

@Dusch4593 LGTM

Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>

Dusch4593 · 2022-06-16T19:01:04Z

Thanks a lot @SSwiniarski and @caupolicandiaz! 🙏🏻

@yangc95 and @KTom101 could one of you take a look at this when you have a sec?

KTom101

@Dusch4593 very minor things from me. Also noticed a few unaddressed changes from @caupolicandiaz were still in the files.

content/general/concepts/database/database.md

content/general/concepts/database/terms/index/index.md

content/python/concepts/files/files.md

content/python/concepts/modules/modules.md

Dusch4593 · 2022-06-17T11:17:45Z

@KTom101 Feedback implemented 😄

Dusch4593 · 2022-06-23T17:33:43Z

@KTom101 Anything left to add or check? Otherwise, we can merge 😄

Edits and new content for General, Python, and SQL

77bad5f

Dusch4593 added enhancement New feature or request python Python entries sql SQL entries general Language Agnostic entries new entry New entry or entries keyword Target keywords shortlist labels Jun 14, 2022

Dusch4593 added 3 commits June 14, 2022 15:15

small edits

3324e66

small edit

56e678f

Merge branch 'main' into py-gen-sql-target-keywords

f6be1b2

SSwiniarski suggested changes Jun 15, 2022

View reviewed changes

SSwiniarski added status: review 1️⃣ completed status: waiting for author labels Jun 15, 2022

Dusch4593 and others added 6 commits June 15, 2022 13:01

Update content/python/concepts/glob-module/glob-module.md

5248ba2

Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>

Update content/python/concepts/glob-module/terms/glob/glob.md

b48e003

Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>

Update content/python/concepts/glob-module/terms/glob/glob.md

4d88920

Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>

Update content/sql/concepts/commands/terms/group-by/group-by.md

8e586a3

Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>

Update content/sql/concepts/commands/commands.md

8d5f5be

Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>

Update content/sql/concepts/commands/commands.md

2d6e03e

Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>

Dusch4593 assigned SSwiniarski Jun 15, 2022

Dusch4593 removed the status: waiting for author label Jun 15, 2022

SSwiniarski approved these changes Jun 15, 2022

View reviewed changes

Dusch4593 requested review from KTom101, caupolicandiaz and yangc95 June 15, 2022 17:09

Merge branch 'main' into py-gen-sql-target-keywords

afc72e2

caupolicandiaz suggested changes Jun 15, 2022

View reviewed changes

caupolicandiaz added the status: waiting for author label Jun 15, 2022

Update content/general/concepts/database/terms/index/index.md

fcbfabc

Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>

Dusch4593 and others added 6 commits June 15, 2022 18:36

Update content/general/concepts/database/terms/index/index.md

18b0a22

Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>

Update content/general/concepts/encapsulation/encapsulation.md

04df027

Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>

Update content/python/concepts/files/files.md

0247e0f

Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>

Update content/python/concepts/modules/modules.md

fc0465f

Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>

Merge branch 'main' into py-gen-sql-target-keywords

5211e15

Update content/python/concepts/glob-module/glob-module.md

a77b6c9

Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>

Dusch4593 assigned caupolicandiaz Jun 15, 2022

Dusch4593 added the status: review 2️⃣ completed label Jun 15, 2022

Dusch4593 added 2 commits June 15, 2022 19:08

implement feedback

021c59d

Merge branch 'py-gen-sql-target-keywords' of https://github.com/Dusch…

4755103

…4593/docs into py-gen-sql-target-keywords

caupolicandiaz approved these changes Jun 16, 2022

View reviewed changes

Dusch4593 and others added 2 commits June 16, 2022 14:59

Update content/general/concepts/encapsulation/encapsulation.md

788dc93

Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>

Merge branch 'main' into py-gen-sql-target-keywords

3e1c76b

Dusch4593 removed the status: waiting for author label Jun 16, 2022

Merge branch 'main' into py-gen-sql-target-keywords

47fd6b9

KTom101 reviewed Jun 17, 2022

View reviewed changes

KTom101 added status: review 3️⃣ completed status: waiting for author labels Jun 17, 2022

Dusch4593 assigned KTom101 Jun 17, 2022

implemented feedback

c0d690e

Dusch4593 removed the status: waiting for author label Jun 17, 2022

Merge branch 'main' into py-gen-sql-target-keywords

16efe12

Merge branch 'main' into py-gen-sql-target-keywords

3fe98c2

Dusch4593 merged commit f9aa58e into Codecademy:main Jun 25, 2022

Edits and new content for General, Python, and SQL #808

Edits and new content for General, Python, and SQL #808

Uh oh!

Conversation

Dusch4593 commented Jun 14, 2022

Description

Type of Change

Checklist

Uh oh!

SSwiniarski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dusch4593 commented Jun 15, 2022

Uh oh!

SSwiniarski left a comment

Choose a reason for hiding this comment

Uh oh!

caupolicandiaz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dusch4593 commented Jun 15, 2022

Uh oh!

caupolicandiaz commented Jun 16, 2022

Uh oh!

Dusch4593 commented Jun 16, 2022

Uh oh!

KTom101 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dusch4593 commented Jun 17, 2022

Uh oh!

Dusch4593 commented Jun 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants