Basefont tag #816
Merged
Basefont tag #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dusch4593
suggested changes
Jun 17, 2022
Contributor
Dusch4593
left a comment
Dusch4593
left a comment
There was a problem hiding this comment.
@ethan-master-coding Just a few comments/suggestions from me
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
Contributor
Author
|
@Dusch4593 All edits look good. I accepted the changes. |
not-a-ethan
commented
Jun 18, 2022
| - `color`: What [color](https://www.codecademy.com/resources/docs/css/colors) the font/text should be. The color can be set to a named `color`, hexadecimal or RGB. | ||
| - `face`: What font the text should be. For example, to have the text be `verdana`, the `face` attribute would be set to `face="verdana"`. | ||
| - `size`: Sets the size of the font/text. It can use absolute units and relative units ranging from 1-7. Absolute units are used by `size="5"` or any other number 1-7. Relative units are relative the size of the `<basefont>` tag which is also deprecated. The attribute would look something like this `size="+5"`. | ||
| - `size`: Sets the size of the font/text. It can use absolute units and relative units ranging from 1-7. Absolute units are used by `size="5"` or any other number 1-7. Relative units are relative the size of the [`<basefont>`](https://www.codecademy.com/resources/docs/html/tags/basefont) tag which is also deprecated. The attribute would look something like this `size="+5"`. |
KTom101
suggested changes
Jun 22, 2022
Contributor
KTom101
left a comment
KTom101
left a comment
There was a problem hiding this comment.
@ethan-master-coding A couple of changes from me.
Co-authored-by: KTom101 <kyrathompson@me.com>
Co-authored-by: KTom101 <kyrathompson@me.com>
Contributor
Author
|
@KTom101 All edits look good. I accepted the changes. |
Dusch4593
suggested changes
Jun 23, 2022
Contributor
Dusch4593
left a comment
Dusch4593
left a comment
There was a problem hiding this comment.
@ethan-master-coding Just a few more comments/suggestions from me and I can approve the PR for my review 😄
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
KTom101
approved these changes
Jun 23, 2022
Contributor
Author
|
@Dusch4593 doesn't really matter but you forgot to add the |
Dusch4593
added a commit
to Dusch4593/docs
that referenced
this pull request
Jun 24, 2022
This reverts commit 1e8e129.
Dusch4593
added a commit
to Dusch4593/docs
that referenced
this pull request
Jun 25, 2022
This reverts commit 1e8e129.
Dusch4593
pushed a commit
to Dusch4593/docs
that referenced
this pull request
Jun 25, 2022
* Made the entry for the basefont tag * Update basefont.md * Update content/html/concepts/tags/terms/basefont/basefont.md * Update content/html/concepts/tags/terms/basefont/basefont.md * Update font.md * Update basefont.md * Update content/html/concepts/tags/terms/basefont/basefont.md * Update content/html/concepts/tags/terms/basefont/basefont.md * Update content/html/concepts/tags/terms/basefont/basefont.md * Update content/html/concepts/tags/terms/basefont/basefont.md * formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the
<basefont>tagType of Change
Checklist
mainbranch.*Need to wait until #815 is merged since we should link this to it.