Skip to content

Conversation

@SSwiniarski
Copy link
Contributor

Description

From Target Keyword List

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

@SSwiniarski SSwiniarski added general Language Agnostic entries new entry New entry or entries keyword Target keywords shortlist labels Jun 21, 2022
Copy link
Contributor

@Dusch4593 Dusch4593 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SSwiniarski Just a few comments/suggestions from me 😄

SSwiniarski and others added 4 commits June 25, 2022 10:35
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@SSwiniarski
Copy link
Contributor Author

@Dusch4593, I implemented your suggestions.

Copy link
Contributor

@Dusch4593 Dusch4593 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SSwiniarski LGTM for one more review 👍🏻

Copy link
Contributor

@KTom101 KTom101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SSwiniarski I don't see any edits that are needed. I've suggested a comma in one spot.

Co-authored-by: KTom101 <kyra.thompson@nyu.edu>
@SSwiniarski
Copy link
Contributor Author

@KTom101, I inserted your comma.

@Dusch4593 Dusch4593 merged commit 5ade196 into Codecademy:main Jun 29, 2022
@Dusch4593
Copy link
Contributor

Dusch4593 commented Jun 29, 2022

Once the entry is live, it can be found here: https://www.codecademy.com/resources/docs/general/endianness

@SSwiniarski SSwiniarski deleted the Endianness branch August 11, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

general Language Agnostic entries keyword Target keywords shortlist new entry New entry or entries status: review 1️⃣ completed status: review 2️⃣ completed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants