Skip to content

New Entry C & C++ Macros #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 34 commits into from
Jun 30, 2022
Merged

New Entry C & C++ Macros #824

merged 34 commits into from
Jun 30, 2022

Conversation

@SSwiniarski
Copy link
Contributor

@SSwiniarski SSwiniarski commented Jun 25, 2022

Description

From the Target Keyword list

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

@SSwiniarski SSwiniarski added enhancement New feature or request c++ C++ entries c C entries new entry New entry or entries keyword Target keywords shortlist labels Jun 25, 2022
Dusch4593
Dusch4593 suggested changes Jun 25, 2022
View reviewed changes
Copy link
Contributor

@Dusch4593 Dusch4593 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SSwiniarski Finished with my review and left you some comments/suggestions

@Dusch4593 Dusch4593 self-assigned this Jun 25, 2022
SSwiniarski and others added 14 commits June 25, 2022 11:31
@SSwiniarski @Dusch4593
Update content/c/concepts/macros/macros.md
74cf54d 
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@SSwiniarski @Dusch4593
Update content/c/concepts/macros/macros.md
0d54fb5 
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@SSwiniarski @Dusch4593
Update content/c/concepts/macros/macros.md
2352d5e 
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@SSwiniarski @Dusch4593
Update content/c/concepts/macros/macros.md
6bd96e9 
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@SSwiniarski @Dusch4593
Update content/c/concepts/macros/macros.md
f339de2 
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@SSwiniarski @Dusch4593
Update content/cpp/concepts/macros/macros.md
5361b75 
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@SSwiniarski @Dusch4593
Update content/c/concepts/macros/macros.md
a42e895 
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@SSwiniarski @Dusch4593
Update content/c/concepts/macros/macros.md
491dd7f 
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@SSwiniarski @Dusch4593
Update content/cpp/concepts/macros/macros.md
bab55cc 
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@SSwiniarski @Dusch4593
Update content/c/concepts/macros/macros.md
b558c1d 
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@SSwiniarski @Dusch4593
Update content/cpp/concepts/macros/macros.md
78c8679 
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@SSwiniarski @Dusch4593
Update content/cpp/concepts/macros/macros.md
0d7efc1 
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@SSwiniarski @Dusch4593
Update content/cpp/concepts/macros/macros.md
cf79e68 
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@SSwiniarski @Dusch4593
Update content/cpp/concepts/macros/macros.md
759df64 
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
SSwiniarski and others added 4 commits June 25, 2022 11:33
@SSwiniarski @Dusch4593
Update content/cpp/concepts/macros/macros.md
1f00541 
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@SSwiniarski @Dusch4593
Update content/cpp/concepts/macros/macros.md
e2a0fe2 
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@SSwiniarski @Dusch4593
Update content/cpp/concepts/macros/macros.md
e937c15 
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@SSwiniarski @Dusch4593
Update content/cpp/concepts/macros/macros.md
3ae6480 
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@SSwiniarski
Copy link
Contributor Author

SSwiniarski commented Jun 25, 2022

@Dusch4593, I applied all your suggestions.

Dusch4593
Dusch4593 approved these changes Jun 25, 2022
View reviewed changes
Copy link
Contributor

@Dusch4593 Dusch4593 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SSwiniarski LGTM! 👍🏻

KTom101
KTom101 reviewed Jun 28, 2022
View reviewed changes
Copy link
Contributor

@KTom101 KTom101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SSwiniarski Did a second review of this.

SSwiniarski and others added 5 commits June 29, 2022 06:46
@SSwiniarski
Copy link
Contributor Author

SSwiniarski commented Jun 29, 2022

@KTom101, I implemented your suggestions.

KTom101
KTom101 approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@KTom101 KTom101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SSwiniarski LGTM 👍

@KTom101
Copy link
Contributor

KTom101 commented Jun 30, 2022 •
edited
Loading

@Dusch4593 Anything you want to add with the new additions?

@Dusch4593
Copy link
Contributor

Dusch4593 commented Jun 30, 2022 •
edited
Loading

Everything LGTM! 👍🏻 I just made some headers "Title Case" in ce76f63 and 8371cbf.

@Dusch4593 Dusch4593 merged commit ae6b9f6 into Codecademy:main Jun 30, 2022
@SSwiniarski SSwiniarski deleted the macros branch August 11, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caupolicandiaz caupolicandiaz Awaiting requested review from caupolicandiaz

@yangc95 yangc95 Awaiting requested review from yangc95

2 more reviewers

@Dusch4593 Dusch4593 Dusch4593 approved these changes

@KTom101 KTom101 KTom101 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Dusch4593 Dusch4593

@KTom101 KTom101

Labels

c++ C++ entries c C entries enhancement New feature or request keyword Target keywords shortlist new entry New entry or entries status: review 1️⃣ completed status: review 2️⃣ completed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SSwiniarski @KTom101 @Dusch4593