Skip to content

Conversation

@Dusch4593
Copy link
Contributor

Description

For my team's ongoing keyword target efforts.

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

@Dusch4593 Dusch4593 added enhancement New feature or request general Language Agnostic entries java Java entries git Git entries r R entries new entry New entry or entries keyword Target keywords shortlist labels Jun 25, 2022
Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dusch4593, I did a first review and left a few comments.

@Dusch4593
Copy link
Contributor Author

@SSwiniarski Implemented your feedback 😄

Copy link
Contributor

@SSwiniarski SSwiniarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dusch4593, looks good for review two.

Copy link
Contributor

@caupolicandiaz caupolicandiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dusch4593 a few small comments

Dusch4593 and others added 5 commits June 29, 2022 08:59
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
Co-authored-by: caupolicandiaz <caupolicandiaz@gmail.com>
@Dusch4593
Copy link
Contributor Author

@caupolicandiaz Finished implementing your feedback

Copy link
Contributor

@caupolicandiaz caupolicandiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dusch4593 LGTM

@Dusch4593 Dusch4593 merged commit fefd54e into Codecademy:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request general Language Agnostic entries git Git entries java Java entries keyword Target keywords shortlist new entry New entry or entries r R entries status: review 1️⃣ completed status: review 2️⃣ completed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants