Skip to content

Ethan master coding patch 1 #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 30, 2022
Merged

Ethan master coding patch 1 #831

merged 8 commits into from
Jun 30, 2022

Conversation

@not-a-ethan
Copy link
Contributor

@not-a-ethan not-a-ethan commented Jun 30, 2022

Description

Fix a link

Type of Change

  • Editing an existing entry (fixing a typo, bug, issues, etc)

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

@not-a-ethan not-a-ethan marked this pull request as ready for review June 30, 2022 20:30
Dusch4593
Dusch4593 approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@Dusch4593 Dusch4593 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ethan-master-coding LGTM! 👍🏻

In a9c3aae, I changed the end of the hyperlink back to /abstract-factory-pattern to match the newly updated folder/file name.

@Dusch4593 Dusch4593 self-assigned this Jun 30, 2022
@Dusch4593 Dusch4593 added status: review 1️⃣ completed enhancement New feature or request general Language Agnostic entries labels Jun 30, 2022
@Dusch4593 Dusch4593 merged commit 32f3e27 into Codecademy:main Jun 30, 2022
@not-a-ethan not-a-ethan deleted the ethan-master-coding-patch-1 branch June 30, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Dusch4593 Dusch4593 Dusch4593 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Dusch4593 Dusch4593

Labels

enhancement New feature or request general Language Agnostic entries status: review 1️⃣ completed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@not-a-ethan @Dusch4593