fix(ConnectedFormGroup): Have screen reader read form input error#3098
fix(ConnectedFormGroup): Have screen reader read form input error#3098codecademydev merged 1 commit intomainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 497ef54. ☁️ Nx Cloud last updated this comment at |
jrood
changed the title
jrood
force-pushed
the
jrood.COPS-194
branch
4 times, most recently
from
e5e9fda to
b4f3cb6
Compare
dreamwasp
changed the title
There was a problem hiding this comment.
Checked on VO and it sounds great! There's much more info than before :)
—
We can also take this offline, another thought — @dreamwasp was also curious if there was any follow up tix for other ConnectedFormGroup fields?
E.g. I noticed that the radiogroup didn't read out its error.
and the recurly field for credit cards (which I know you only mentioned the First + Last name in this PR, but did make me curious)
Otherwise, the gamut team can also cut some follow-up tix.
Thanks!
| ); | ||
|
|
||
| const textError = customError || getErrorMessage(error); | ||
| const showError = !!((error || customError) && !hideLabel); |
There was a problem hiding this comment.
Thought on subbing out (error || customError) to just textError?
The getErrorMessage seems to return a truthy value if there is an error
📬Published Alpha Packages:@codecademy/gamut@64.1.1-alpha.497ef5.0 |
|
🚀 Styleguide deploy preview ready! |
3 participants
Overview
Link the error to the form input via
aria-describedbyPR Checklist
Testing Instructions
Organisms>ConnectedForm->ConnectedForm>DocsPlaygroundIf you prefer to test within the portal-app preview env, the same test can be done using
First nameandLast namefields on the logged in checkout page. Login first, then navigate to https://tengu.codecademy.com/checkout?plan_type=directpurchase&PR_ENV=portal-app-pr-10427PR Links and Envs