Skip to content

feat: Add border related logical props#3257

Merged
LinKCoding merged 29 commits intokl-gmt-1451-logical-propsfrom
kl-gmt-1510-logical-border
Feb 6, 2026
Merged

feat: Add border related logical props#3257
LinKCoding merged 29 commits intokl-gmt-1451-logical-propsfrom
kl-gmt-1510-logical-border

Conversation

@LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Jan 30, 2026

Overview

  • Added logical properties for border related CSS properties
    • Border: borderX, borderY, borderTop, borderRight, borderBottom, borderLeft
    • Border Width: borderWidthX, borderWidthY, borderWidthTop, borderWidthRight, borderWidthBottom, borderWidthLeft
    • Border Color: borderColorX, borderColorY, borderColorTop, borderColorRight, borderColorBottom, borderColorLeft
    • Border Style: borderStyleX, borderStyleY, borderStyleTop, borderStyleRight, borderStyleBottom, borderStyleLeft
    • Border Radius: borderRadiusLeft, borderRadiusRight, borderRadiusTop, borderRadiusBottom, borderRadiusTopLeft, borderRadiusTopRight, borderRadiusBottomLeft, borderRadiusBottomRight
  • Updated Stories related to border related props

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1510
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Go to Foundations/System/Props/Border in Storybook
  2. Use the LogicalProps toggle in the toolbar to switch between "Logical" and "Physical" modes
  3. Inspect the rendered elements in each example to verify:
  • In Logical mode: Properties like border-inline-start, border-block-end-width, border-start-start-radius are used
  • In Physical mode: Properties like border-left, border-bottom-width, border-top-left-radius are used
  1. Repeat for Foundations/System/Props/Color to verify border color props
  2. Verify the TokenTable shows the correct properties based on the selected mode
  3. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@LinKCoding LinKCoding requested a review from a team as a code owner January 30, 2026 15:33
@LinKCoding LinKCoding requested review from dreamwasp and sh0ji and removed request for a team January 30, 2026 15:33
@LinKCoding LinKCoding marked this pull request as draft January 30, 2026 15:33
@nx-cloud
Copy link

nx-cloud bot commented Jan 30, 2026

View your CI Pipeline Execution ↗ for commit f7c2f59


☁️ Nx Cloud last updated this comment at 2026-02-06 19:46:30 UTC

@codecov
Copy link

codecov bot commented Jan 30, 2026

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@LinKCoding LinKCoding marked this pull request as ready for review February 4, 2026 16:01
Base automatically changed from kl-gmt-1508v2-margin-padding to kl-gmt-1451-logical-props February 6, 2026 15:55
@LinKCoding LinKCoding mentioned this pull request Feb 6, 2026
6 tasks
@codecademydev
Copy link
Collaborator

📬 Published Alpha Packages:

@codecademy/gamut@68.0.1-alpha.4746be.0
@codecademy/gamut-icons@9.54.3-alpha.4746be.0
@codecademy/gamut-illustrations@0.58.3-alpha.4746be.0
@codecademy/gamut-kit@0.6.580-alpha.4746be.0
@codecademy/gamut-patterns@0.10.22-alpha.4746be.0
@codecademy/gamut-styles@17.11.3-alpha.4746be.0
@codecademy/gamut-tests@5.2.20-alpha.4746be.0
@codecademy/styleguide@79.0.1-alpha.4746be.0
@codecademy/variance@0.25.3-alpha.4746be.0

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

@LinKCoding LinKCoding merged commit e852afa into kl-gmt-1451-logical-props Feb 6, 2026
13 checks passed
@LinKCoding LinKCoding deleted the kl-gmt-1510-logical-border branch February 6, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants