chore: Update SelectDropdown Multi select to use logical properties#3331
chore: Update SelectDropdown Multi select to use logical properties#3331LinKCoding merged 3 commits intocass-gmt-1601from
Conversation
|
View your CI Pipeline Execution ↗ for commit 27f8062 ☁️ Nx Cloud last updated this comment at |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many --target=build --all |
❌ Failed | 42s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-04-22 15:18:07 UTC
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## cass-gmt-1601 #3331 +/- ##
================================================
Coverage ? 89.19%
================================================
Files ? 250
Lines ? 4702
Branches ? 1590
================================================
Hits ? 4194
Misses ? 500
Partials ? 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
📬 Published Alpha Packages:
|
|
🚀 Styleguide deploy preview ready! Preview URL: https://69e8ea543b6840a925a562e3--gamut-preview.netlify.app |
|
🚀 Styleguide deploy preview ready! Preview URL: https://69e8ea54d14c773ddfba8384--gamut-preview.netlify.app |
| borderEndEndRadius: 0, | ||
| borderEndStartRadius: theme.borderRadii.md, | ||
| borderStartEndRadius: 0, | ||
| borderStartStartRadius: theme.borderRadii.md, |
There was a problem hiding this comment.
Opting to hardcode logical properties here since:
- it's a styles.ts file so using the useLogicalProperties just adds some bloat that might require clean up
- Rendering is still the same as when physical properties are used
but long story short, probably not worth jumping through hoops to ensure that users have the option of physical vs logical when logical properties do the same thing in LTR but also support RTL

Overview
PR Checklist
Testing Instructions
Don't make me tap the sign.
PR Links and Envs