Skip to content

fix(Popover): addressing left/right beak#3332

Merged
LinKCoding merged 4 commits intocass-gmt-1601-tooltip-bugfrom
kl-gmt-1601-tooltip-beak
Apr 24, 2026
Merged

fix(Popover): addressing left/right beak#3332
LinKCoding merged 4 commits intocass-gmt-1601-tooltip-bugfrom
kl-gmt-1601-tooltip-beak

Conversation

@LinKCoding
Copy link
Copy Markdown
Contributor

@LinKCoding LinKCoding commented Apr 23, 2026

Overview

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1601
  • Version plan added/updated (or not needed)
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to Popover
  2. Go to an individual story and see that the beak changes left/center/right
  3. Test against Physical LTR and Logical LTR/RTL
  4. Go to InfoTip's Default story
  5. Make it the floating variant, check that InfoTip stories still look and work as intended in both RTL + LTR
  6. ...
  7. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 23, 2026

View your CI Pipeline Execution ↗ for commit 796476a


☁️ Nx Cloud last updated this comment at 2026-04-24 13:11:16 UTC

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (cass-gmt-1601-tooltip-bug@5bbd863). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on cass-gmt-1601-tooltip-bug.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             cass-gmt-1601-tooltip-bug    #3332   +/-   ##
============================================================
  Coverage                             ?   89.26%           
============================================================
  Files                                ?      251           
  Lines                                ?     4722           
  Branches                             ?     1599           
============================================================
  Hits                                 ?     4215           
  Misses                               ?      499           
  Partials                             ?        8           
Flag Coverage Δ
pull-request 89.26% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecademydev
Copy link
Copy Markdown
Collaborator

📬 Published Alpha Packages:

Package Version npm Diff
@codecademy/gamut 68.2.3-alpha.112ad1.0 npm diff
@codecademy/gamut-icons 9.57.3-alpha.112ad1.0 npm diff
@codecademy/gamut-illustrations 0.58.10-alpha.112ad1.0 npm diff
@codecademy/gamut-kit 0.6.593-alpha.112ad1.0 npm diff
@codecademy/gamut-patterns 0.10.29-alpha.112ad1.0 npm diff
@codecademy/gamut-styles 17.13.2-alpha.112ad1.0 npm diff
@codecademy/gamut-tests 5.3.4-alpha.112ad1.0 npm diff
@codecademy/variance 0.26.2-alpha.112ad1.0 npm diff
eslint-plugin-gamut 2.4.4-alpha.112ad1.0 npm diff

@github-actions
Copy link
Copy Markdown
Contributor

@LinKCoding LinKCoding marked this pull request as ready for review April 24, 2026 13:16
@LinKCoding LinKCoding requested a review from a team as a code owner April 24, 2026 13:16
@LinKCoding LinKCoding changed the title addressing corner beaks for infotips fix(Popover): addressing left/right beak Apr 24, 2026
Copy link
Copy Markdown
Contributor

@aresnik11 aresnik11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LinKCoding LinKCoding merged commit 5b1c675 into cass-gmt-1601-tooltip-bug Apr 24, 2026
16 checks passed
@LinKCoding LinKCoding deleted the kl-gmt-1601-tooltip-beak branch April 24, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants