Skip to content

fix(Input): update Input padding to use logical properties#3338

Merged
aresnik11 merged 2 commits intomainfrom
ajr-input-rtl-fix
May 4, 2026
Merged

fix(Input): update Input padding to use logical properties#3338
aresnik11 merged 2 commits intomainfrom
ajr-input-rtl-fix

Conversation

@aresnik11
Copy link
Copy Markdown
Contributor

@aresnik11 aresnik11 commented May 4, 2026

Overview

Updates Input padding to use logical properties.

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1633
  • Version plan added/updated (or not needed)
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to Input story
  2. View Text story in LTR
  3. Confirm it looks as expected
  4. View Text story in RTL
  5. Confirm there is padding
  6. View custom icon story
  7. Confirm it looks good in RTL

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@aresnik11 aresnik11 requested a review from a team as a code owner May 4, 2026 15:38
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 4, 2026

View your CI Pipeline Execution ↗ for commit b5b61d9


☁️ Nx Cloud last updated this comment at 2026-05-04 17:35:12 UTC

@aresnik11 aresnik11 requested a review from dreamwasp May 4, 2026 15:40
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.91%. Comparing base (fdc5965) to head (b5b61d9).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3338      +/-   ##
==========================================
- Coverage   90.40%   89.91%   -0.50%     
==========================================
  Files         405      276     -129     
  Lines        6649     5730     -919     
  Branches     2159     1897     -262     
==========================================
- Hits         6011     5152     -859     
+ Misses        630      570      -60     
  Partials        8        8              
Flag Coverage Δ
main ?
pull-request 89.91% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecademydev
Copy link
Copy Markdown
Collaborator

📬 Published Alpha Packages:

Package Version npm Diff
@codecademy/gamut 68.4.1-alpha.b49ddb.0 npm diff
@codecademy/gamut-icons 9.57.4-alpha.b49ddb.0 npm diff
@codecademy/gamut-illustrations 0.58.11-alpha.b49ddb.0 npm diff
@codecademy/gamut-kit 0.6.595-alpha.b49ddb.0 npm diff
@codecademy/gamut-patterns 0.10.30-alpha.b49ddb.0 npm diff
@codecademy/gamut-styles 17.14.1-alpha.b49ddb.0 npm diff
@codecademy/gamut-tests 5.3.5-alpha.b49ddb.0 npm diff
@codecademy/variance 0.26.2-alpha.b49ddb.0 npm diff
eslint-plugin-gamut 2.4.4-alpha.b49ddb.0 npm diff

@aresnik11 aresnik11 merged commit 826b8c1 into main May 4, 2026
18 checks passed
@aresnik11 aresnik11 deleted the ajr-input-rtl-fix branch May 4, 2026 17:36
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants