PhpBrowser's submitForm() is not submitting empty $button correctly

[ThomasLandauer]

When submitting a form as shown in the example at http://codeception.com/docs/modules/PhpBrowser#submitForm

$I->submitForm(
    '#userForm',
    [
        'user' => [
            'login' => 'Davert',
            'password' => '123456',
            'agree' => true
        ]
    ],
    'submitButton'
);

... the submitButton gets submitted as "submitButton":null. (This is probably due to the fact that I'm using a <button> rather than an <input type="submit"> - so the button itself doesn't have a value.) The problem is that now Symfony doesn't recognize the button as being clicked, since it expects different data (which is how real browsers do it): "submitButton":"".

So I would suggest:

• Either accept an array as the $button parameter of submitForm() like this: array('submitButton'=>'')
• Or (preferably): If the element doesn't have a value, just submit the empty string '' instead of null

Details

• Codeception version: 2.3.5
• PHP Version: 7.1

[Naktibalda]

Was it really a problem with PhpBrowser?
I doubt that it can send null value over HTTP.

[ThomasLandauer]

Well, it's hard to say, since Codeception's output looks like this:

[Parameters] {"myForm[name]":"Thomas","myForm":{"name":"Thomas","submitButton":""}}

I.e. the "regular" fields are listed twice, and the submit button is only included in the second JSON object.

That's why I suggested to dump the actual Request object to make clear what's really being submitted and how: Codeception/lib-innerbrowser#16

But what I can say for now is that submitForm()s third parameter $button is never working for me in Symfony.

So it might be better to remove this third parameter completely and just tell people to include the button in the second parameter - depending on their backend/framework.

[Naktibalda]

Fields listed twice certainly looks like a bug. submitButton in the form array is probably Symfony specific.

Button parameter not only uses value of the button, but also checks formaction attribute of the button and changes form target url accordingly if it exists.