Skip to content

Fix PHP 8.5 deprecation warning #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TavoNiievez merged 3 commits into from
Nov 28, 2025
Merged

Fix PHP 8.5 deprecation warning #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ab2b76
chore(ci): add php 8.5
W0rma Nov 28, 2025
9bc2c1b
chore(ci): bump dependencies
W0rma Nov 28, 2025
3695ea1
fix: use empty string as array key explicitly because using null is d…
W0rma Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,20 @@ jobs:

strategy:
matrix:
php: [8.1, 8.2, 8.3, 8.4]
php: [8.1, 8.2, 8.3, 8.4, 8.5]

steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
# this ini directive seems to be off by default in PHP 8.5
# see https://github.com/php/php-src/issues/20279
# enable it because codeception relies on it.
ini-values: register_argc_argv=1

- name: Validate composer.json and composer.lock
run: composer validate
Expand Down
2 changes: 1 addition & 1 deletion src/Codeception/Lib/InnerBrowser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1054,7 +1054,7 @@ protected function getFormFor(Crawler $node): SymfonyForm
$this->fail('The selected node is not a form and does not have a form ancestor.');
}

$identifier = $form->attr('id') ?: $form->attr('action');
$identifier = $form->attr('id') ?: $form->attr('action') ?? '';
if (!isset($this->forms[$identifier])) {
Comment on lines +1057 to 1058
Copy link
Contributor Author

@W0rma W0rma Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lower PHP versions already converted null array keys to an empty string (https://3v4l.org/5UbfM) implicitly.

However, using null is deprecated in PHP 8.5.
That's why an empty string is used explicitly.

$this->forms[$identifier] = $this->getFormFromCrawler($form);
}
Expand Down