Skip to content

Added support for AMQPTable #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DenuxPlays wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −3
Open

Added support for AMQPTable #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Codeception/Module/AMQP.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
use PhpAmqpLib\Connection\AMQPStreamConnection;
use PhpAmqpLib\Exception\AMQPProtocolChannelException;
use PhpAmqpLib\Message\AMQPMessage;
use PhpAmqpLib\Wire\AMQPTable;

/**
* This module interacts with message broker software that implements
Expand Down Expand Up @@ -166,7 +167,7 @@ public function declareExchange(
bool $auto_delete = true,
bool $internal = false,
bool $nowait = false,
?array $arguments = null,
array|AMQPTable|null $arguments = null,
Copy link
Contributor

@W0rma W0rma Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TavoNiievez Should this change being considered a BC break because it changes the type hint of a public method declared in a non-final class?

Copy link
Author

@DenuxPlays DenuxPlays Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah probably

Copy link
Author

@DenuxPlays DenuxPlays Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that is a decision I cannot make.
Just publish the next release by incrementing the major version ig

?int $ticket = null
) {
return $this->getChannel()->exchange_declare(
Expand Down Expand Up @@ -203,7 +204,7 @@ public function declareQueue(
bool $exclusive = false,
bool $auto_delete = true,
bool $nowait = false,
?array $arguments = null,
array|AMQPTable|null $arguments = null,
?int $ticket = null
): ?array {
return $this->getChannel()->queue_declare(
Expand Down Expand Up @@ -239,7 +240,7 @@ public function bindQueueToExchange(
string $exchange,
string $routing_key = '',
bool $nowait = false,
?array $arguments = null,
array|AMQPTable|null $arguments = null,
?int $ticket = null
) {
return $this->getChannel()->queue_bind(
Expand Down