Skip to content

Enable native lazy objects if possible to fix the CI when using symfony 8 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enable native lazy objects if possible to fix the CI when using symfony 8 #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad15a4d
Enable native lazy objects whenever possible.
W0rma Oct 28, 2025
3e6d1d7
Fix usage of deprecated phpstan config option
W0rma Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ parameters:
- tests/data/doctrine_fixtures/TestFixture1.php
- tests/data/doctrine_fixtures/TestFixture2.php
- tests/_support/UnitTester.php
checkMissingIterableValueType: false
Copy link
Contributor Author

@W0rma W0rma Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed the following warning when running phpstan locally:

Note: Using configuration file /var/www/html/phpstan.neon.
⚠️  You're using a deprecated config option checkMissingIterableValueType ⚠️️

It's strongly recommended to remove it from your configuration file
and add the missing array typehints.

If you want to continue ignoring missing typehints from arrays,
add missingType.iterableValue error identifier to your ignoreErrors:

parameters:
        ignoreErrors:
                -
                        identifier: missingType.iterableValue

reportUnmatchedIgnoredErrors: true
ignoreErrors:
- path: tests/
Expand All @@ -21,3 +20,4 @@ parameters:
message: '#Method \S+ has no return type specified#'
- path: tests/
message: '#(?:Method|Property) .+ with generic (?:interface|class) \S+ does not specify its types#'
- identifier: missingType.iterableValue
18 changes: 9 additions & 9 deletions tests/unit/Codeception/Module/Doctrine2Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,18 +81,18 @@ protected function _setUp()
$connection = DriverManager::getConnection(['driver' => $sqliteDriver, 'memory' => true]);

if (version_compare(InstalledVersions::getVersion('doctrine/orm'), '3', '>=')) {
$this->em = new EntityManager(
$connection,
ORMSetup::createAttributeMetadataConfiguration([$dir], true)
);
$configuration = ORMSetup::createAttributeMetadataConfiguration([$dir], true);
} else {
$this->em = new EntityManager(
$connection,
// @phpstan-ignore-next-line
ORMSetup::createAnnotationMetadataConfiguration([$dir], true)
);
// @phpstan-ignore-next-line
$configuration = ORMSetup::createAnnotationMetadataConfiguration([$dir], true);
}

if (PHP_VERSION_ID >= 80400 && method_exists($configuration, 'enableNativeLazyObjects')) {
$configuration->enableNativeLazyObjects(true);
}

$this->em = new EntityManager($connection, $configuration);

(new SchemaTool($this->em))->createSchema([
$this->em->getClassMetadata(CompositePrimaryKeyEntity::class),
$this->em->getClassMetadata(PlainEntity::class),
Expand Down