Add support for laminas/laminas-diactoros v2.#13
Merged
Naktibalda merged 1 commit intoCodeception:masterfrom Dec 26, 2021
samuelnogueira:diactoros_v2
Merged
Add support for laminas/laminas-diactoros v2.#13Naktibalda merged 1 commit intoCodeception:masterfrom samuelnogueira:diactoros_v2
laminas/laminas-diactoros v2.#13Naktibalda merged 1 commit intoCodeception:masterfrom
samuelnogueira:diactoros_v2
Conversation
* Main workflow now tests both 1.8 and 2.0 versions of laminas diactoros for each PHP version. * Use `update` instead of `install` to install composer dependencies to allow `--with` param. This change will also address the following warning in workflow, since composer.lock file is not in version control: > No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Contributor
Author
|
Please confirm if changing the github action workflow to validate compatibility with both diactoros major versions is acceptable. |
Member
|
Looks good to me. |
Member
|
Released as 3.0.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.