Update REST.php#31
Merged
Merged
Conversation
* I created a new header "JSONPath", and moved the *general* JSONPath infos from `grabDataFromResponseByJsonPath` to it - in preparation for removing `flow/jsonpath` as a dependency, see Codeception#24 (comment) * I removed the "Parts" header, cause it seemed useless to me
Closed
Member
|
Parts header is not useless, it could be clearer, but, I think, the assumption is that the reader is familiar with parts functionality from some other documentation page.
See |
This was referenced Nov 3, 2020
Updating JsonPath, according to Codeception#36
Bringing back the parts, according to Codeception/Codeception#6026
Member
Author
|
This is ready for merging now. Question: What's the reason for having those parts in this module? Is there any other module that conflicts with the entire REST module? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grabDataFromResponseByJsonPathto it - in preparation for removingflow/jsonpathas a dependency, see Abandoned dependency #24 (comment)