Merged
Conversation
Collaborator
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves runtime performance by memoizing Optml_Settings::get_site_settings() so repeated calls within the same request reuse a previously built settings array instead of rebuilding it each time.
Changes:
- Add request-local memoization to
Optml_Settings::get_site_settings()using a static cache. - Reuse the cached settings array for subsequent calls in the same request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Soare-Robert-Daniel
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Improved performance of
get_site_settingsby storing the result in a static variable and reusing it during the same request.Closes #1031
Other information: