Allow box_values() to accept string input#2761
Merged
selul merged 2 commits intodevelopmentfrom Mar 19, 2026
Merged
Conversation
Co-authored-by: selul <3330746+selul@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update box_values to accept string input without array
Allow Mar 19, 2026
box_values() to accept string input
Contributor
Bundle Size Diff
|
Contributor
|
Plugin build for 4a32002 is ready 🛎️!
|
Contributor
E2E TestsPlaywright Test Status: Performance ResultsserverResponse: {"q25":413.7,"q50":416.6,"q75":422.7,"cnt":10}, firstPaint: {"q25":415.4,"q50":516.3,"q75":534.4,"cnt":10}, domContentLoaded: {"q25":1541.7,"q50":1551,"q75":1566.6,"cnt":10}, loaded: {"q25":1542.1,"q50":1551.35,"q75":1566.9,"cnt":10}, firstContentfulPaint: {"q25":3221.2,"q50":3240.75,"q75":3254,"cnt":10}, firstBlock: {"q25":6590.9,"q50":6637.9,"q75":6792.9,"cnt":10}, type: {"q25":13.01,"q50":13.36,"q75":13.55,"cnt":10}, typeWithoutInspector: {"q25":11.53,"q50":12.01,"q75":12.66,"cnt":10}, typeWithTopToolbar: {"q25":15.77,"q50":16.24,"q75":16.66,"cnt":10}, typeContainer: {"q25":7.25,"q50":8.01,"q75":8.49,"cnt":10}, focus: {"q25":50.47,"q50":53.24,"q75":54.61,"cnt":10}, inserterOpen: {"q25":15.78,"q50":17.18,"q75":19.9,"cnt":10}, inserterSearch: {"q25":5.4,"q50":5.52,"q75":5.58,"cnt":10}, inserterHover: {"q25":2.31,"q50":2.45,"q75":2.68,"cnt":20}, loadPatterns: {"q25":1054.09,"q50":1075.71,"q75":1128.99,"cnt":10}, listViewOpen: {"q25":80.34,"q50":85.47,"q75":96.96,"cnt":10} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSS_Utility::box_values()passed its$boxargument directly toarray_map(), causing a fatal error when a string (e.g. a raw CSS value like'10px') was provided instead of an array.Changes
inc/css/class-css-utility.php— Added an early return inbox_values()when$boxis not an array; updated@paramtype toarray|string.tests/test-css.php— Addedtest_box_values_string_input()covering string pass-through cases.Original prompt
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.