Fix chart creation nonce verification mismatch#1261
Merged
vytisbulkevicius merged 3 commits intodevelopmentfrom Mar 4, 2026
Merged
Fix chart creation nonce verification mismatch#1261vytisbulkevicius merged 3 commits intodevelopmentfrom
vytisbulkevicius merged 3 commits intodevelopmentfrom
Conversation
The security PR that was merged to development added nonce action
parameters to nonce creation and uploadData verification, but forgot
to update _handleTypesPage verification. This caused a mismatch where:
- Nonces were created WITH action: wp_create_nonce('visualizer-upload-data')
- But _handleTypesPage verified WITHOUT action: wp_verify_nonce($nonce)
- Result: Nonce verification failed, chart creation broken
This fix updates _handleTypesPage to verify WITH the action parameter
to match the nonce creation, allowing charts to be created successfully
while maintaining all security improvements.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
💂♂️ PR Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Contributor
Layout.php line 983 was unconditionally accessing Visualizer_Pro::ACTION_FETCH_DATA even in the free version, causing a fatal error when creating charts. The nonce creation now checks if PRO version is active before accessing the Visualizer_Pro class, matching the pattern used for the action parameter. Security fix from previous commit remains intact: - Chart.php line 958: Nonce verification with 'visualizer-upload-data' action - uploadData() method: Capability checks and per-chart ownership validation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Fixed incorrect case usage: Visualizer_PRO -> Visualizer_Pro This resolves the PHPStan check failure that was blocking CI. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
vytisbulkevicius
added a commit
that referenced
this pull request
Mar 4, 2026
Merged PR #1261 security fixes from development: - Fix chart creation nonce verification mismatch - Fix Visualizer_Pro class not found error in free version - Fix PHPStan class name case error Resolved conflict in Types.php by accepting the security fix (nonce with 'visualizer-upload-data' action parameter). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
🎉 This PR is included in version 3.11.15 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the nonce verification mismatch that broke chart creation in the development branch.
Problem
The security PR added nonce action parameters but had a bug in
_handleTypesPage():wp_create_nonce('visualizer-upload-data')_handleTypesPage()verified WITHOUT action:wp_verify_nonce($nonce)Solution
Updated
_handleTypesPage()nonce verification to include the action parameter:Changes
classes/Visualizer/Module/Chart.phpTesting
✅ Charts can now be created successfully
✅ Security vulnerability remains fixed (CVE)
🤖 Generated with Claude Code