Restored svg menu icon size and styles#334
Merged
vytisbulkevicius merged 1 commit intodevelopmentfrom Apr 23, 2026
Merged
Conversation
girishpanchal30
added
the
pr-checklist-skip
pirate-bot
added
the
pr-checklist-complete
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a regression where SVG menu icons selected via Image → Media Library render too small due to incorrect escaping of pre-built HTML attribute strings in get_svg_icon().
Changes:
- Escapes SVG-derived
width/heightvalues at the point they are inserted into the attribute string (rather than escaping the entire attribute fragment). - Stops escaping
$width,$height, and$styleas whole attribute strings when building the final<img>markup, restoring correctwidth/height/styleoutput.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Soare-Robert-Daniel
approved these changes
Apr 14, 2026
Contributor
|
🎉 This PR is included in version 0.13.23 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Escaped the width and height of the SVG icon.
Check before Pull Request is ready:
Closes #333