Generic Fryer #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JavierCane
approved these changes
Jan 24, 2018
Member
There was a problem hiding this comment.
Good one @joan-miralles!
Just a little suggestion regarding the GenericFryer trait name 🙂
Tell me if you want to apply that suggestion in this very same PR. If so, I would wait for them before merging it.
|
|
||
| import scala.concurrent.Future | ||
|
|
||
| trait GenericFryer[IngredientType, FriedIngredientType] { |
Member
There was a problem hiding this comment.
Good one!
However, we should try to avoid specifying these kind of prefixes and suffixes. I'm referring to the GenericXxx or XxxInterface ones. They doesn't bring any value so we can get rid of them 🙂
Author
|
Fixed! Thanks for the suggestion! |
Member
|
Good work! Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.