Fixed a bug where notes (NoteGroup) were not destroyed when StrumLine was destroyed. #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
well it does but thats only because Garbage collecter destroys it prob. peak fix |
Member
|
yah LJ is right the Garbage Collector does clear it out, but why not |
Member
|
imma test it rq |
|
Do ya thing.. Also why cant i download it...
…________________________________
From: NexIsDumb ***@***.***>
Sent: Saturday, January 4, 2025 2:19 PM
To: CodenameCrew/CodenameEngine ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [CodenameCrew/CodenameEngine] Fixed a bug where notes (NoteGroup) were not destroyed when StrumLine was destroyed. (PR #519)
imma test it rq
—
Reply to this email directly, view it on GitHub<#519 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BFBBJG4P2SHR6ZDFYK352FD2JA66XAVCNFSM6AAAAABUS2CVESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZRGQYDEMBRGE>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Member
?? |
Member
|
Alr looks good |
|
These are emailing me too you know..
…________________________________
From: NexIsDumb ***@***.***>
Sent: Saturday, January 4, 2025 2:23 PM
To: CodenameCrew/CodenameEngine ***@***.***>
Cc: a fellow mc player ***@***.***>; Comment ***@***.***>
Subject: Re: [CodenameCrew/CodenameEngine] Fixed a bug where notes (NoteGroup) were not destroyed when StrumLine was destroyed. (PR #519)
Merged #519<#519> into main.
—
Reply to this email directly, view it on GitHub<#519 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BFBBJG77YXLIRQ6GESQ2JQD2JA7NXAVCNFSM6AAAAABUS2CVESVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVHAYTMMJTGQ2TCNY>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Contributor
|
me when I clicked the "Watch" button on CNE and im confused why im getting notified |
Contributor
|
...GitHub has emailing from a GitHub email?? |
Member
|
When you comment you get updated from every message because you are subscribed to the pr automatically |
Contributor
|
yeah lmao Get notified |
Contributor
Yeah, GitHub does do that in general for all forum posts across all of its forum services. It happens in Discussions and Issues because they all use the same framework for these kinds of things. |
|
bruh
…________________________________
From: ItsLJcool ***@***.***>
Sent: Saturday, January 4, 2025 2:28 PM
To: CodenameCrew/CodenameEngine ***@***.***>
Cc: a fellow mc player ***@***.***>; Comment ***@***.***>
Subject: Re: [CodenameCrew/CodenameEngine] Fixed a bug where notes (NoteGroup) were not destroyed when StrumLine was destroyed. (PR #519)
yeah lmao
Get notified [:trollface:]
—
Reply to this email directly, view it on GitHub<#519 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BFBBJGYA5AR32JIP2CMVL232JA76NAVCNFSM6AAAAABUS2CVESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZRGQYDGNZTGE>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I use Google Translate)