Skip to content

Fix component alphabets using the width of the wrong component #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Raltyro merged 1 commit into from
Mar 29, 2026
Merged

Fix component alphabets using the width of the wrong component #937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions source/funkin/menus/ui/Alphabet.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ final class AlphabetComponent {
public var cos:Float;
public var scaleX:Float;
public var scaleY:Float;

public var flipX:Bool;
public var flipY:Bool;

Expand Down Expand Up @@ -281,7 +281,7 @@ class Alphabet extends FlxSprite {
var anim = getLetterAnim(letter, data, __component, i);
//if (cantrace)
//trace(anim.name + " | " + __component.anim + " | " + frames.frames[anim.frames[0]]);
advance = (Math.isNaN(advance)) ? getAdvance(letter, anim, data) : advance;
advance = (Math.isNaN(advance) && i >= data.startIndex) ? getAdvance(letter, anim, data) : advance;

if (anim == null || __renderData.alpha <= 0.0)
continue;
Expand Down Expand Up @@ -551,7 +551,7 @@ class Alphabet extends FlxSprite {
angle: angle,
cos: angleCos,
sin: angleSin,

flipX: node.get("flipX") == "true",
flipY: node.get("flipY") == "true",

Expand Down Expand Up @@ -607,7 +607,7 @@ class Alphabet extends FlxSprite {
angle: angle,
cos: angleCos,
sin: angleSin,

flipX: xFlip,
flipY: yFlip,

Expand All @@ -630,7 +630,7 @@ class Alphabet extends FlxSprite {
angle: angle,
cos: angleCos,
sin: angleSin,

flipX: xFlip,
flipY: yFlip,

Expand Down Expand Up @@ -664,7 +664,7 @@ class Alphabet extends FlxSprite {
var xScale:Float = Std.parseFloat(node.get("scaleX")).getDefaultFloat(1.0);
var yScale:Float = Std.parseFloat(node.get("scaleY")).getDefaultFloat(1.0);
var advance:Float = Std.parseFloat(node.get("advance"));

var xFlip = node.get("flipX") == "true";
var yFlip = node.get("flipY") == "true";

Expand All @@ -685,7 +685,7 @@ class Alphabet extends FlxSprite {
angle: angle,
cos: angleCos,
sin: angleSin,

flipX: xFlip,
flipY: yFlip,

Expand Down