Conversation
Contributor
Author
Closed
zanjonke
approved these changes
Apr 14, 2026
Contributor
zanjonke
left a comment
zanjonke
left a comment
There was a problem hiding this comment.
Looks good. We discussed in person how the render_time works, why the removal of the with console.status. This PR looks good to go. Make sure to squash the lint commits.
NejcS
force-pushed
the
feat/post_rendering_output
branch
from
7ec56f7 to
84a8113
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds console printing after rendering is done (successful or not). It counts the successfully rendered functionalities and measures the time it takes to render them (not including pauses).
Example:
What's not done here completely is to handle all possible errors and display them nicely like the one below:
I would prefer to get this PR out and tackle that separately so that this PR doesn't grow too much.