Conversation
zanjonke
force-pushed
the
fix/exit_with_error
branch
from
07f1fe5 to
87e4665
Compare
Contributor
Author
|
@kaja-s please take a look at the message here and come up with a better example :) |
pedjaradenkovic
approved these changes
Apr 16, 2026
| @@ -59,7 +59,6 @@ def run(self): | |||
| previous_state = deepcopy(self.render_context.state) | |||
| self.render_context.script_execution_history.should_update_script_outputs = False | |||
| # Reset error message at start of each iteration to prevent stale data | |||
Contributor
There was a problem hiding this comment.
remove this line as it's not needed
Collaborator
|
I think this should be the message we communicate:
|
zanjonke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
Unexpected error format: dictissue. This happens after 20 failed attempts to fix the conformance tests. The fix is to let theExitWithErroraction return theRenderErrorobject rather thanprevious_action_payload.Putting this PR in WIP stage since we also need to update the message. The message
We've already tried to fix the issue by recreating the conformance tests but tests still fail. Please fix the issues manually. FRID: {self.frid_context.frid}, Render ID: {self.run_state.render_id}doesnt feel right.