fix(build): remove package-lock.json from install stamp prerequisites#133
Merged
CoderCoco merged 1 commit intoMay 10, 2026
Merged
Conversation
package-lock.json is an output of npm install, not an input. Listing it in PKG_JSONS caused Make to immediately bail with "No rule to make target 'app/package-lock.json'" on fresh clones where the file does not yet exist. Closes #132 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a Makefile dependency cycle that caused make tf-plan (and other targets depending on .make/install.stamp) to fail on a fresh clone by removing app/package-lock.json from the install stamp prerequisites, since that lockfile is produced by npm install and may not exist beforehand.
Changes:
- Removed
app/package-lock.jsonfromPKG_JSONS, so.make/install.stampdepends only on workspacepackage.jsonfiles.
CoderCoco
deleted the
worktree-claude+issue-132-fix-makefile-install-stamp
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #132
Summary
app/package-lock.jsonwas listed inPKG_JSONSas a hard prerequisite for.make/install.stamp, but it is an output ofnpm install, not an input — making the dependency circularNo rule to make target 'app/package-lock.json', needed by '.make/install.stamp'PKG_JSONS; the workspacepackage.jsonfiles are sufficient for detecting when a re-install is neededTest plan
make tf-plan(ormake build-lambdas) on a fresh clone with noapp/package-lock.jsonpresent — confirm the install stamp runs successfully instead of bailing with a missing-target error