Skip to content

chore(terraform): anonymize tfvars examples and remove game_servers default#39

Merged
CoderCoco merged 1 commit into
mainfrom
claude/anonymize-tfvars-examples-7xHgw
Apr 30, 2026
Merged

chore(terraform): anonymize tfvars examples and remove game_servers default#39
CoderCoco merged 1 commit into
mainfrom
claude/anonymize-tfvars-examples-7xHgw

Conversation

@CoderCoco
Copy link
Copy Markdown
Owner

Summary

This PR removes hardcoded default game server configurations and makes the game_servers variable required, shifting to a more flexible example-driven approach. The example configuration is now generic and commented out, requiring users to explicitly define their own game servers.

Key Changes

  • Removed default game server definitions from variables.tf: Deleted pre-configured examples for Palworld, Satisfactory, and FoundryVTT that were provided as defaults
  • Made game_servers variable required: Removed the default block, making this variable mandatory for all deployments
  • Updated terraform.tfvars.example:
    • Changed hosted_zone_name from "codercoco.com" to generic "example.com"
    • Replaced concrete game server examples with a single commented-out Palworld example
    • Added comprehensive documentation explaining the game server structure and how to add custom entries
    • Updated ACM certificate domain example to use example.com
  • Updated variable descriptions:
    • hosted_zone_name: Now explicitly states it must already exist and provides example format
    • acm_certificate_domain: Clarified default behavior when null
  • Updated documentation in terraform.md to reflect the new required variable approach

Implementation Details

The change encourages explicit configuration over implicit defaults, reducing the risk of users accidentally deploying unwanted services. Users must now copy the example configuration and customize it for their specific needs, making the deployment process more intentional and transparent.

https://claude.ai/code/session_011XwGyddBHntiQYnmtgePVw

- Replace codercoco.com references with example.com in terraform.tfvars.example,
  variables.tf descriptions, and the terraform.md variables table
- Remove the default game_servers map from variables.tf — the variable is now
  required so operators must explicitly define their own servers in terraform.tfvars
- Replace the live game_servers block in terraform.tfvars.example with a
  commented-out Palworld example showing the expected shape

https://claude.ai/code/session_011XwGyddBHntiQYnmtgePVw
Copilot AI review requested due to automatic review settings April 30, 2026 03:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes opinionated default Terraform game server configurations and shifts the module to an explicit, example-driven configuration model where users must define their own game_servers map.

Changes:

  • Removed the built-in default game_servers map so deployments must explicitly define game servers.
  • Made hosted_zone_name (and previously game_servers) required inputs by removing defaults and clarifying variable descriptions.
  • Updated terraform.tfvars.example and Terraform docs to use generic example.com guidance and a commented-out game_servers example.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
terraform/variables.tf Removes default game server definitions; updates variable descriptions; removes default hosted_zone_name.
terraform/terraform.tfvars.example Replaces concrete defaults with generic example.com and a commented example game_servers block.
docs/docs/components/terraform.md Updates variable table to reflect hosted_zone_name as required and documents the generic format.

Comment thread terraform/variables.tf
Comment on lines +49 to 51
description = "Domain for the ACM TLS certificate used by the ALB (e.g. *.example.com). Defaults to *.{hosted_zone_name} when null."
type = string
default = null # When null, defaults to *.{hosted_zone_name}
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title doesn’t follow the repo’s Conventional Commits requirement (it should start with a type like feat/fix/chore/etc, optional scope, then ": "). Please rename the PR to something like "refactor(terraform): remove default game server configs" (or another appropriate type/scope).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed — PR title updated to chore(terraform): anonymize tfvars examples and remove game_servers default.


Generated by Claude Code

@CoderCoco CoderCoco changed the title Remove default game server configs and use generic example chore(terraform): anonymize tfvars examples and remove game_servers default Apr 30, 2026
@CoderCoco CoderCoco merged commit ff71f60 into main Apr 30, 2026
11 checks passed
@CoderCoco CoderCoco deleted the claude/anonymize-tfvars-examples-7xHgw branch April 30, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants