chore(terraform): anonymize tfvars examples and remove game_servers default#39
Conversation
- Replace codercoco.com references with example.com in terraform.tfvars.example, variables.tf descriptions, and the terraform.md variables table - Remove the default game_servers map from variables.tf — the variable is now required so operators must explicitly define their own servers in terraform.tfvars - Replace the live game_servers block in terraform.tfvars.example with a commented-out Palworld example showing the expected shape https://claude.ai/code/session_011XwGyddBHntiQYnmtgePVw
There was a problem hiding this comment.
Pull request overview
This PR removes opinionated default Terraform game server configurations and shifts the module to an explicit, example-driven configuration model where users must define their own game_servers map.
Changes:
- Removed the built-in default
game_serversmap so deployments must explicitly define game servers. - Made
hosted_zone_name(and previouslygame_servers) required inputs by removing defaults and clarifying variable descriptions. - Updated
terraform.tfvars.exampleand Terraform docs to use genericexample.comguidance and a commented-outgame_serversexample.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| terraform/variables.tf | Removes default game server definitions; updates variable descriptions; removes default hosted_zone_name. |
| terraform/terraform.tfvars.example | Replaces concrete defaults with generic example.com and a commented example game_servers block. |
| docs/docs/components/terraform.md | Updates variable table to reflect hosted_zone_name as required and documents the generic format. |
| description = "Domain for the ACM TLS certificate used by the ALB (e.g. *.example.com). Defaults to *.{hosted_zone_name} when null." | ||
| type = string | ||
| default = null # When null, defaults to *.{hosted_zone_name} |
There was a problem hiding this comment.
PR title doesn’t follow the repo’s Conventional Commits requirement (it should start with a type like feat/fix/chore/etc, optional scope, then ": "). Please rename the PR to something like "refactor(terraform): remove default game server configs" (or another appropriate type/scope).
There was a problem hiding this comment.
Fixed — PR title updated to chore(terraform): anonymize tfvars examples and remove game_servers default.
Generated by Claude Code
Summary
This PR removes hardcoded default game server configurations and makes the
game_serversvariable required, shifting to a more flexible example-driven approach. The example configuration is now generic and commented out, requiring users to explicitly define their own game servers.Key Changes
variables.tf: Deleted pre-configured examples for Palworld, Satisfactory, and FoundryVTT that were provided as defaultsgame_serversvariable required: Removed thedefaultblock, making this variable mandatory for all deploymentsterraform.tfvars.example:hosted_zone_namefrom"codercoco.com"to generic"example.com"example.comhosted_zone_name: Now explicitly states it must already exist and provides example formatacm_certificate_domain: Clarified default behavior when nullterraform.mdto reflect the new required variable approachImplementation Details
The change encourages explicit configuration over implicit defaults, reducing the risk of users accidentally deploying unwanted services. Users must now copy the example configuration and customize it for their specific needs, making the deployment process more intentional and transparent.
https://claude.ai/code/session_011XwGyddBHntiQYnmtgePVw