Release 1.0.1 #29

CoderGamester · 2026-01-14T23:20:32Z

Changed:

Updated dependency com.gamelovers.dataextensions to com.gamelovers.gamedata
Updated assembly definitions to reference GameLovers.GameData

Summary by CodeRabbit

Refactor: Updated dependencies and assembly definitions to use GameLovers.GameData.
Refactor: Replaced Math.Abs with MathfloatP.Abs and System.Math.Abs.
Test: Adjusted test dependencies to align with the updated GameLovers.GameData.

chore(deps): update dependency to com.gamelovers.gamedata build(release): bump version to 1.0.1 and update changelog

coderabbitai · 2026-01-14T23:20:37Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-01-14T23:20:44Z

CodeRabbit

Walkthrough

The changes involve updating dependencies and assembly definitions across various files to align with the new com.gamelovers.gamedata package. Additionally, some code modifications were made in RngService.cs for namespace inclusion and method replacements.

Changes

File	Summary
AGENTS.md, CHANGELOG.md, Runtime/GameLovers.Services.asmdef	Updated dependency to `com.gamelovers.gamedata`. Updated assembly definitions to reference `GameLovers.GameData`.
Runtime/RngService.cs	Added `using GameLovers.GameData;` to the namespace. Replaced `Math.Abs` with `MathfloatP.Abs`. Replaced `Math.Abs` with `System.Math.Abs`.
Tests/EditMode/GameLovers.Services.Tests.asmdef, Tests/PlayMode/GameLovers.Services.Tests.Playmode.asmdef	Updated dependency to `com.gamelovers.gamedata`. Adjusted assembly definitions to reference `GameLovers.GameData`.

Poem

In the realm of code, changes dance and play,
Dependencies shift like night into day.
With precision and care, we update and align,
Ensuring our systems continue to shine. 🐇✨

Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

github-actions

CodeRabbit

Commits

Files that changed from the base of the PR and between 9f02bca and 60665a7 commits.

Files selected (6)

AGENTS.md (2)
CHANGELOG.md (1)
Runtime/GameLovers.Services.asmdef (1)
Runtime/RngService.cs (3)
Tests/EditMode/GameLovers.Services.Tests.asmdef (1)
Tests/PlayMode/GameLovers.Services.Tests.Playmode.asmdef (1)

Files ignored due to filter (1)

package.json

Files skipped from review due to trivial changes (1)

Runtime/GameLovers.Services.asmdef

Review comments generated (6)

Review: 5
LGTM: 1

Tips

Chat with CodeRabbit Bot (`@coderabbitai`)

Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

github-actions · 2026-01-14T23:20:59Z

CHANGELOG.md

+## [1.0.1] - 2026-01-14
+
+**Changed**:
+- Updated dependency `com.gamelovers.dataextensions` to `com.gamelovers.gamedata`
+- Updated assembly definitions to reference `GameLovers.GameData`


CodeRabbit

The changes in the CHANGELOG.md file look good, reflecting the update to version 1.0.1 with the necessary modifications.

+ ## [1.0.1] - 2026-01-14 + + **Changed**: + - Updated dependency `com.gamelovers.dataextensions` to `com.gamelovers.gamedata` + - Updated assembly definitions to reference `GameLovers.GameData` +

github-actions · 2026-01-14T23:20:59Z

AGENTS.md

 - **Unity**: 6000.0+
 - **Dependencies** (see `package.json`)
-  - `com.gamelovers.dataextensions` (**0.6.2**) (contains `floatP`, used by `RngService`)
+  - `com.gamelovers.gamedata` (**1.0.0**) (contains `floatP`, used by `RngService`)


CodeRabbit

The dependency version for com.gamelovers.gamedata has been updated. Ensure compatibility with this new version.

- - `com.gamelovers.dataextensions` (**0.6.2**) (contains `floatP`, used by `RngService`) + - `com.gamelovers.gamedata` (**1.0.0**) (contains `floatP`, used by `RngService`)

github-actions · 2026-01-14T23:20:59Z

Tests/EditMode/GameLovers.Services.Tests.asmdef

        "UnityEngine.TestRunner",
        "UnityEditor.TestRunner",
        "GameLovers.Services",
-        "GameLovers.DataExtensions",
+        "GameLovers.GameData",
        "Unity.PerformanceTesting"
    ],
    "includePlatforms": [


CodeRabbit

Note: This review was outside of the patch, but no patch was found that overlapped with it. Original lines [22-22]

The reference to "GameLovers.DataExtensions" has been replaced with "GameLovers.GameData", ensuring consistency with the updated dependencies.

- "GameLovers.DataExtensions", + "GameLovers.GameData",

github-actions · 2026-01-14T23:20:59Z

Tests/PlayMode/GameLovers.Services.Tests.Playmode.asmdef

        "UnityEditor.TestRunner",
        "GameLovers.Services",
-        "GameLovers.DataExtensions",
+        "GameLovers.GameData",


CodeRabbit

The dependency has been updated from "GameLovers.DataExtensions" to "GameLovers.GameData". Ensure that this change aligns with the actual dependencies and usage in the test files.

- "GameLovers.DataExtensions", + "GameLovers.GameData",

github-actions · 2026-01-14T23:20:59Z

Runtime/RngService.cs

+			if (min > max || (!maxInclusive && MathfloatP.Abs(min - max) < floatP.Epsilon))
 			{
 				throw new IndexOutOfRangeException("The min range value must be less the max range value");
 			}

-			if (Math.Abs(min - max) < floatP.Epsilon)
+			if (MathfloatP.Abs(min - max) < floatP.Epsilon)


CodeRabbit

There is a potential issue with the logic in the Range method related to comparing floating-point numbers. The condition checks if min > max or if (!maxInclusive && MathfloatP.Abs(min - max) < floatP.Epsilon). However, the subsequent check if (MathfloatP.Abs(min - max) < floatP.Epsilon) seems redundant as it's already covered in the first condition. This redundancy can be removed to simplify the logic.

- if (MathfloatP.Abs(min - max) < floatP.Epsilon) - { - return min; - }

Issue in Line 285:

In the GenerateRngState method, there is a potential issue with the calculation of value. The expression _basicSeed - (seed == int.MinValue ? int.MaxValue : System.Math.Abs(seed)) might lead to unexpected results when seed is equal to int.MinValue. It's advisable to handle this edge case more explicitly to ensure correct behavior.

- var value = _basicSeed - (seed == int.MinValue ? int.MaxValue : System.Math.Abs(seed)); + var value = _basicSeed - (seed == int.MinValue ? int.MaxValue : Math.Abs(seed));

General Comment:

Ensure consistency in using either System.Math or MathfloatP for mathematical operations throughout the codebase to maintain clarity and avoid confusion.

Review Comments

224-229: Redundant logic in the Range method.

285: Potential issue with handling seed value in the GenerateRngState method.

refactor(rng): use MathfloatP for deterministic operations

60665a7

chore(deps): update dependency to com.gamelovers.gamedata build(release): bump version to 1.0.1 and update changelog

github-actions bot reviewed Jan 14, 2026

View reviewed changes

CoderGamester merged commit ec6964f into master Jan 14, 2026
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.0.1 #29

Release 1.0.1 #29

Uh oh!

CoderGamester commented Jan 14, 2026 •

edited by github-actions bot

Loading

Uh oh!

coderabbitai bot commented Jan 14, 2026

Review skipped

Uh oh!

github-actions bot commented Jan 14, 2026 •

edited

Loading

CodeRabbit Pro

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot Jan 14, 2026

Uh oh!

github-actions bot Jan 14, 2026

Uh oh!

github-actions bot Jan 14, 2026

Uh oh!

github-actions bot Jan 14, 2026

Uh oh!

github-actions bot Jan 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Release 1.0.1 #29

Release 1.0.1 #29

Uh oh!

Conversation

CoderGamester commented Jan 14, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 14, 2026

Review skipped

Uh oh!

github-actions bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

CodeRabbit Pro

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Chat with CodeRabbit Bot (@coderabbitai)

Code suggestions

Pausing incremental reviews

Uh oh!

github-actions bot Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 14, 2026

Choose a reason for hiding this comment

Issue in Line 285:

General Comment:

Review Comments

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CoderGamester commented Jan 14, 2026 •

edited by github-actions bot

Loading

github-actions bot commented Jan 14, 2026 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)