fix: improve graceful shutdown handling for MCP server#91
Merged
CoderGamester merged 1 commit intoCoderGamester:mainfrom Dec 30, 2025
Merged
Conversation
- Add isShuttingDown flag to prevent double-shutdown race conditions - Add SIGTERM and SIGHUP signal handlers in addition to SIGINT - Add stdin close/end/error handlers for when MCP client disconnects - Handle EPIPE/EOF errors gracefully as expected disconnection - Call server.close() during shutdown for proper cleanup - Exit with code 1 for actual errors vs code 0 for clean shutdown 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CoderGamester
approved these changes
Dec 30, 2025
Owner
CoderGamester
left a comment
There was a problem hiding this comment.
Good improvement for a clean shutdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code