Feature - Tambahkan fitur download screenshot di halaman preview screenshot #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widget tersebut berfungsi untuk menampilkan loading center full screen overlay
…abase lokal Perbaikan task name yang kosong ketika dimasukkan kedalam database lokal pada saat stop timer. Ini disebabkan karena function `doTakeScreenshot` bersifat `async` dan setelah pemanggilan function `doTakeScreenshot` ada kode untuk set `selectedTask` menjadi null dan ini menyebabkan ketika diinsert ke database lokal `selectedTask`-nya menjadi null. Jadi, solusinya adalah simpan variable `selectedTask` kedalam variable `selectedTaskTemp`.
…Message` didalam widget_helper.dart
Fitur download ini dibuat dalam 2 pengkondisian yaitu, jika file photo-nya ada di server dan ada di lokal. Untuk file photo yang ada di server ini untuk fitur download photo yang sudah naik fotonya ke server. Sementara, untuk file photo yang di lokal ini berarti, file photo-nya masih di lokal.
…didownload atau tidak Untuk saat ini, download foto hanya dipakai di halaman sync_page.dart dan report_screenshot_page.dart saja. Dan download foto ini hanya berlaku untuk foto user tersebut dan super admin.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 116 116
Lines 1892 1892
=========================================
Hits 1892 1892 ☔ View full report in Codecov by Sentry. |
CoderJava
deleted the
feature/tambahan-fitur-download-screenshot-di-halaman-preview-screenshot
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untuk saat ini, fitur download foto hanya dipakai untuk dowload foto screenshot saja. Baik foto screenshot yang belum sync maupun yang sudah sync. Dan fitur download foto ini hanya bisa mendownload foto-foto user yang sedang login dan user yang role-nya super admin.
Buat.fitur.download.screenshot.di.halaman.preview.photo.mov