Clean up redundant patterns across block implementations#39
Merged
Conversation
The propertyName field was redundant — enum values WATER, LAVA, NONE map directly to their lowercase strings.
Replace inline listOf(BlockFace.NORTH, ...) with the inherited ADJACENT_FACES constant.
Both factory subclasses had identical active/inactive logic. Add abstract activeBlockId property and implement it once in the base.
Extracts the repeated "${blockX},${blockY},${blockZ}" pattern into
a Location.coordinates extension property in AtlasConfig.kt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FluidType.propertyName— use.name.lowercase()instead, since values were just lowercase enum namesADJACENT_FACESinPowerMerger— last remaining inline face listgetVisualStateBlockId()up toMaterialFactory— both factory subclasses had identical active/inactive logic, now driven by abstractactiveBlockIdLocation.coordinatesextension property — replaces 22 instances of"${blockX},${blockY},${blockZ}"interpolation across 14 files