Fix splitter round-robin distribution and remove dead code#44
Merged
Fix splitter round-robin distribution and remove dead code#44
Conversation
Splitters previously always iterated output faces in a fixed order, causing resources to always favor the same direction. Both PowerSplitter and FluidSplitter now track a nextOutputIndex that advances past the last successful push, cycling through output faces evenly over time.
The panel logged "is not generating power because it is not daytime" every 10 seconds per panel during night, creating significant log noise with no diagnostic value.
These data classes were never used in production code — BlockPersistence handles all serialization directly. Also removes redundant locationKey companion delegation from all three registry subclasses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PowerSplitterandFluidSplitternow cycle through output faces instead of always favoring the same direction. Each tracks anextOutputIndexthat advances past the last successful push.PowerBlockDataandFluidBlockDataclasses (never called from production code —BlockPersistencehandles serialization directly). Also removed redundantlocationKeycompanion delegation from all three registry subclasses.