Some tuplets do not merge correctly

[cheap-glitch]

Your environment

• Version used: 0.9.3.169
• Platform used: JavaScript
• Rendering engine used: SVG
• Browser Name and Version: Firefox 65.0.1
• Operating System and version (desktop or mobile): ArchLinux (desktop)
• Link to your project:

Expected Results

Triplets (and other tuplets) should merge together.

Observed Results

A bug has appeared in the latest build (0.9.3.169) where some triplets don't merge correctly. Given the following alphatex:

:8 5.3{tu 3}*3 5.3{b (0 2)}{tu 3} 5.3{b (0 2)}{tu 3} 5.3{b (0 2)}{tu 3}

Version 0.9.3.164 will render correctly:

But 0.9.3.169 will produce this:

Quite strangely, the triplets do actually merge when they have a bend effect attached to them.

Steps to Reproduce (for bugs)

Create a tab with the following alphatex in version 0.9.3.169:

:8 5.3{tu 3}*3

Possible Solution

[Danielku15]

This bug is a side effect of the changes in #228 . If you apply the tuplet as "note effect" instead of "beat effect" it gets reset. If you write the following code it works (notice that the tuplet is after the multiplier):

:8 5.3*3{tu 3} 5.3{b (0 2)}{tu 3} 5.3{b (0 2)}{tu 3} 5.3{b (0 2)}{tu 3}

Nevertheless I fixed the issue and ensured that the tuplet is not removed in case it is added in the note effects.